feat(settings): open web settings in an in-page dialog#354
Open
AAEE86 wants to merge 2 commits into
Open
Conversation
AAEE86
commented
Jul 17, 2026
AAEE86
commented
- replace the web settings window with a responsive modal
- reuse existing settings routes through a same-origin iframe
- support loading state, close button, overlay and Escape dismissal
- add tests for dialog events and interactions
- replace the web settings window with a responsive modal - reuse existing settings routes through a same-origin iframe - support loading state, close button, overlay and Escape dismissal - add tests for dialog events and interactions
- replace the browser commit window with a responsive embedded modal - close the modal after commit or cancel and support Escape dismissal - preserve the desktop Tauri window behavior - add event and dialog regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.