Skip to content

fix: skip importing response types for binary endpoints #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santiagomed merged 1 commit into from
Mar 13, 2026
Merged

fix: skip importing response types for binary endpoints #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions xdk-gen/templates/python/client_class.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ from .models import (
{% for operation in operations %}
{% if operation.request_body %}
{{ operation.class_name }}Request,
{% if operation.responses and "200" in operation.responses or operation.responses and "201" in operation.responses %}
{{ operation.class_name }}Response,
{% endif %}
{% elif operation.responses and "200" in operation.responses or operation.responses and "201" in operation.responses %}
{# Only import response types for operations that return JSON (not binary) #}
{% set response_200 = operation.responses["200"] if operation.responses and "200" in operation.responses else none %}
{% set response_201 = operation.responses["201"] if operation.responses and "201" in operation.responses else none %}
{% set has_json_response = (response_200 and response_200.content and "application/json" in response_200.content) or (response_201 and response_201.content and "application/json" in response_201.content) %}
{% if has_json_response %}
{{ operation.class_name }}Response,
{% endif %}
{% endfor %}
Expand Down
8 changes: 5 additions & 3 deletions xdk-gen/templates/typescript/client_class.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ import {
{% for operation in operations -%}
{% if operation.request_body -%}
{{ operation.class_name }}Request,
{% if operation.responses and "200" in operation.responses or operation.responses and "201" in operation.responses -%}
{{ operation.class_name }}Response,
{% endif -%}
{% elif operation.responses and "200" in operation.responses or operation.responses and "201" in operation.responses -%}
{# Only import response types for operations that return JSON (not binary) #}
{% set response_200 = operation.responses["200"] if operation.responses and "200" in operation.responses else none -%}
{% set response_201 = operation.responses["201"] if operation.responses and "201" in operation.responses else none -%}
{% set has_json_response = (response_200 and response_200.content and "application/json" in response_200.content) or (response_201 and response_201.content and "application/json" in response_201.content) -%}
{% if has_json_response -%}
{{ operation.class_name }}Response,
{% endif -%}
{% endfor -%}
Expand Down
Loading