Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses several major and minor issues present in the previous version. In particular:
.eigvalfile;_tb.datfile;Parsing
parser_optics_xatu_dim.f90was refactored to simplify future development.The reading of the XATU
.eigvalfile was updated to accommodate changes in its header format introduced in a recent XATU version.parser_wannier90_tb.f90now stores hoppings and position matrix elements using the indices explicitly read from the file, rather than assuming loop indices.input_parser.f90was refactored to accept input parameters in any order. It now supports bothgaussianandlorentzianbroadening, withgaussianset as the default.Conductivities
A missing factor of$2\pi$ was corrected in
sigma_first_ex.f90.ome_sp.f90now computes the Berry connection in the z direction, and thesigma_*routines write the corresponding z-components of the conductivity tensor.All linear-response calculations now reproduce XATU’s results.