Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion home-mixer/candidate_hydrators/quote_hydrator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ impl Hydrator<ScoredPostsQuery, PostCandidate> for QuoteHydrator {
.into_iter()
.collect();

let fetch_quoted_duration = query.params.get(EnableQuotedVqvDurationCheck);
let fetch_quoted_duration =
query.params.get(EnableQuotedVqvDurationCheck) || query.exclude_videos;
let quoted_tweet_ids: Vec<u64> = if fetch_quoted_duration {
resolved
.iter()
Expand Down
33 changes: 30 additions & 3 deletions home-mixer/filters/video_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ impl Filter<ScoredPostsQuery, PostCandidate> for VideoFilter {
_query: &ScoredPostsQuery,
candidates: Vec<PostCandidate>,
) -> FilterResult<PostCandidate> {
let (kept, removed): (Vec<_>, Vec<_>) = candidates
.into_iter()
.partition(|c| c.min_video_duration_ms.is_none());
let (kept, removed): (Vec<_>, Vec<_>) = candidates.into_iter().partition(|c| {
c.min_video_duration_ms.is_none() && c.quoted_video_duration_ms.is_none()
});

FilterResult { kept, removed }
}
Expand Down Expand Up @@ -96,4 +96,31 @@ mod tests {
assert_eq!(result.kept.len(), 2);
assert!(result.removed.is_empty());
}

#[test]
fn test_removes_quotes_of_videos() {
let query = ScoredPostsQuery {
exclude_videos: true,
..Default::default()
};

let candidates = vec![
PostCandidate {
tweet_id: 1,
quoted_video_duration_ms: Some(5000),
..Default::default()
},
PostCandidate {
tweet_id: 2,
quoted_video_duration_ms: None,
..Default::default()
},
];

let result = VideoFilter.filter(&query, candidates);
assert_eq!(result.kept.len(), 1);
assert_eq!(result.kept[0].tweet_id, 2);
assert_eq!(result.removed.len(), 1);
assert_eq!(result.removed[0].tweet_id, 1);
}
}