Fail closed when QuoteHydrator TES or socialgraph lookup fails - #117
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Fail closed when QuoteHydrator TES or socialgraph lookup fails#117Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For You
QuoteHydratortreats TES and socialgraph failure as "not a quote".TES miss or
Errwas cached asquoted_tweet_id = None. Later VF, mute, and blocked-by never see the inner tweet. Following Night Owl already carriesquoted_tweet_idon the search hit, so reverse-chron still VF-evaluates the quote.Socialgraph
check_blocked_byusedunwrap_or_default(). Empty set =>quoted_author_blocks_viewer = false. FollowingFollowingBlockedByHydratorreturnsErrfor the batch on the same RPC failure.QuoteHydrator(phoenix_candidate_pipeline.rs)should_drop_ancillary(needs Some quoted id),AuthorSocialgraphFilterquoted blocked-byFollowingBlockedByHydratorfail-closes graph errorsThis is not PR 7 (mixer author graph filter). This is not PR 94 (core TES wiping retweet/reply ids). This is not PR 23 (mute quoted author when the id is present).
Fix
Do not cache TES lookup failure. Surface
Errsoupdatedoes not write a fake None. Fail the batch when socialgraph blocked-by errors, matching Following.Genuine
Ok(None)(not a quote) is still cached.Tests
cargo: cannot run. Public dump has no Home Mixer manifest.