Stop Following VF from scoring quoted posts at TimelineHome - #115
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop Following VF from scoring quoted posts at TimelineHome#115Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Following reverse-chron fetches every attached post at
TimelineHome, including quoted tweets and conversation ancestors. For You already fetches those ids atTimelineHomeRecommendations.NSFW_HIGH_PRECISION,DO_NOT_AMPLIFY, spam-high-recall, and the other OON-only Drop rules are Interstitial (or Allow) on Home and Drop on Recs.should_drop_ancillaryonly treatsAction::Drop.AncillaryVFFilteris on the Following post-selection path.A followee quoting an NSFW / DoNotAmplify post therefore survives Following, while the same quote is dropped on For You.
VFFollowingCandidateHydratorcollectstweet_id,ancestors,quoted_tweet_id,retweeted_tweet_idinto one vec and callsget_result(..., TimelineHome, ...)AncillaryVFFilter(drop_ancillary_posts)VFCandidateHydrator(Phoenix / For You) already puts quotes and ancestors onTimelineHomeRecommendationsThis is not PR 55 (For You dual-role HashMap merge). This is not PR 90 (two-map residual on that hydrator). This is not fail-open on miss.
Fix
Keep Following primaries (and retweet originals) on
TimelineHome. Fetch quotes and ancestors onTimelineHomeRecommendations. Do not collapse the two maps: primary visibility reads Home, ancillary drop reads Recs (quotes/ancestors) and Home (retweet originals, unchanged).Tests
drop_ancillary_posts = true; primary stays Interstitialcargo: cannot run. Public dump has no Home Mixer manifest.
Still-open leftover
For You still pushes
retweeted_tweet_idonto the Home vec even when the wrapper is OON. Separate class. Do not mix it here.