Skip to content

fix: use Homebrew tap app bot identity - #18

Merged
robjtede merged 1 commit into
mainfrom
fix/homebrew-tap-bot-identity
Aug 17, 2026
Merged

fix: use Homebrew tap app bot identity#18
robjtede merged 1 commit into
mainfrom
fix/homebrew-tap-bot-identity

Conversation

@robjtede

@robjtede robjtede commented Aug 17, 2026

Copy link
Copy Markdown
Member

Makes generated tap commits use the x52-homebrew-tap-updater GitHub App bot identity.

The previous release-bot noreply address associates commits with an unrelated ordinary GitHub user. The new address uses the App bot numeric user ID and login, which GitHub resolves to the App bot.

Adds fixture assertions for both Git author settings.

Validated with nix develop -c just check.

Summary by CodeRabbit

  • Chores
    • Updated Homebrew tap releases to use the automated bot identity when creating commits.
    • Added validation to ensure the tap checkout has the expected Git author information configured before committing.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b744b4cb-2ec9-4511-a7b3-3458d7b35d1e

📥 Commits

Reviewing files that changed from the base of the PR and between 4253f74 and c686581.

📒 Files selected for processing (2)
  • release-tools/test.bash
  • release-tools/update-homebrew-tap.py

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Homebrew tap updater now commits with a tap-specific bot identity. The test verifies the configured Git user name and noreply email.

Changes

Homebrew tap bot identity

Layer / File(s) Summary
Configure and verify tap bot identity
release-tools/update-homebrew-tap.py, release-tools/test.bash
The updater defines the Homebrew tap bot login and numeric ID, configures Git with the bot name and ID-based noreply email, and tests both local settings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c6865

This localized change makes generated Homebrew tap commits use the intended GitHub App bot identity and adds assertions for both author settings. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to use the Homebrew tap app bot identity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/homebrew-tap-bot-identity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robjtede
robjtede marked this pull request as ready for review August 17, 2026 19:13
@robjtede
robjtede merged commit 8ad7012 into main Aug 17, 2026
3 checks passed
@robjtede
robjtede deleted the fix/homebrew-tap-bot-identity branch August 17, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant