Repository navigation
Conversation
Run the configured lint registry for compile and check, preserving finding codes, severities, source locations, evidence classes, and exit behavior. Reuse the lint policy flags and prevent compile writes for error findings. Document the diagnostic contract and cover default warnings, JSON findings, project policy, CLI overrides, and errors before output or selection. Fixes #1032
Collaborator
Author
|
Addressed both findings from the first review in commit 5059100, pushed to
Verification:
No findings were deferred or found to contradict the approved issue/architecture. There are no GitHub review threads to resolve. The workflow change remains subject to CODEOWNERS review. Remote CI is running on the pushed commit. PR #1035 is ready for follow-up review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileandchecknow include enabled lint findings in their normal diagnostics and severity counts. A script with nested array binding therefore reports the same warning aslint; raising that rule toerrorexits 1 and prevents compile output from being written.Both commands reuse the lint registry and accept the same project configuration, local rule files, disablement, and severity overrides as
lint. JSON retains the diagnostic shape, including source locations and evidence class. CLI documentation and regressions cover these contracts. The existing nested-binding rule and OPY lowering are unchanged.Verification:
cargo fmt --all -- --check: passed.cargo clippy --workspace --all-targets --all-features -- -D warnings: passed.cargo test --workspace --all-targets --all-features </dev/null: running; the earlier run identified expected presentation changes, and the affected snapshots and terminal expectation have been updated and reviewed.git diff --checkand the repository size guard: passed.Acceptance regressions compare compile/check with existing lint findings, cover JSON, warning counts, severity overrides, disabled rules, project configuration precedence, unknown-rule refusal, compile destination preservation, and error verdicts before selection.
python3 /Users/teakowa/Repos/wrightkit/.task-scratch/orch/scratch-1032/verify-acceptance.py: passed. Runs check/lint/analyze/inspect/compile on the issue's minimized OPY expression in en-US and zh-CN using installed first-party OPY provider 0.3.27, and on the existing Bastion prophet reproducer and Bastion Workshop fixture. Compares codes, severities, evidence, messages, and source locations againstlint --all; verifies error exits, unchanged output with lint disabled, and local YAML rule-file handling.CI-pinned LPP mock-provider integration: all 17 normally ignored tests passed after building reference commit
416b293e26e6fb2d29061608a493a7aecd2ce14fin scratch. RanLPP_MOCK_PROVIDER=<scratch>/lpp-reference/target/debug/lpp-mock-provider cargo test --locked -p wright-lpp -p wright-driver --test mock_provider --test lpp --test provider_edit -- --ignored.scripts/test-cli-github-actions.sh "$PWD/target/debug/wright"with GitHub Actions and summary-file environment: passed.Ablation: compile/check call the existing registry evaluator directly; removed the unnecessary full semantic-index construction. Reused the policy parser, diagnostic envelope, selection and exit handling. Moved the compile CLI implementation and its existing prompt test into a module to satisfy the no-growth guard on
main.rs.Unverified: no Overwatch client import or full current Bastion source-project build was performed. Verification uses the issue's OPY expression and the repository's pinned Workshop inputs; it does not establish a new client importability guarantee. The final workspace test run and remote CI are pending at PR creation. No UI files changed, so UI gates do not apply.
Fixes #1032