Repository navigation
Conversation
Refine the existing nested-binder-lambda warning to require an element or index read in the nested iterator's source or per-element arguments. Keep reads confined to deeper iterator bodies from creating redundant warnings, and explain the unconfirmed client import risk in diagnostics and docs. Cover all iterator pairs, source-only reads, deeper scopes, CLI locations, severity overrides, and rule disablement without changing OPY lowering. Fixes #1032
Restore the existing lint rule and OPY behavior before implementing the owner-approved compile/check diagnostic integration.
Run the configured lint registry for compile and check, preserving finding codes, severities, source locations, evidence classes, and exit behavior. Apply the same lint policy flags on both commands and refuse compile output when a lint finding has error severity. Document the diagnostic contract and cover warning counts, JSON findings, project policy, CLI overrides, and failure before output or selection. Fixes #1032
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileandcheckpreviously reported a clean result when the lint registry already identified a static risk. Both now include the enabled lint findings in normal diagnostics and summary counts, as required by the owner decision on #1032.lint. Warnings preserve success; error-level lint findings fail and prevent compile output from replacing an existing destination.Verification:
cargo test -p wright-cli --test compile_check_lint --test compile_check_lint_policy: passed (4 tests).cargo fmt --all -- --check: passed.git diff --checkand the repository size guard: passed.check,lint,analyze,inspect, andcompileon the issue's OPY expression inen-USandzh-CN: all succeeded;compile/checkcarry the same static-indicator warning aslint.reproducer-bastion-prophet.wsandbastion.owfixtures: all succeeded;compile/checkdiagnostic finding sets matchlint(16 and 19 findings respectively).Ablation: reused the existing registry, configuration parser, diagnostic shape, and verdict machinery; introduced no policy switch, result schema, dependency, or rule changes. Removed duplicate project-policy coverage while retaining distinct stdin and path/config regressions.
Unverified: no Overwatch client was available, so client importability and the exact iterator nesting limit remain unconfirmed. The complete current Bastion source project was not rebuilt; validation used the issue's minimized OPY expression and existing pinned project artifacts. No UI files changed, so UI gates do not apply. Remote CI is pending.
Fixes #1032