Skip to content

Fix router to properly set $_SERVER variables for entry points and pretty permalinks #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix router to properly set $_SERVER variables for entry points and pretty permalinks #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1db2efb
Initial plan
Copilot Nov 1, 2025
ac29aff
Fix router to support pretty permalinks and multiple entry points
Copilot Nov 1, 2025
9223c05
Fix failing tests: simplify scenarios and use explicit http protocol
Copilot Nov 1, 2025
3218908
Use wp option update instead of wp rewrite structure in test
Copilot Nov 1, 2025
b5fc77b
Merge branch 'main' into copilot/support-pretty-permalinks
swissspidy Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions features/server.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,24 @@ Feature: Serve WordPress locally
When I run `curl -sS localhost:8181/license.txt > /tmp/license.txt`
And I run `cmp /tmp/license.txt license.txt`
Then STDOUT should be empty

Scenario: Access wp-login.php
Given a WP install
And I launch in the background `wp server --host=localhost --port=8182`

When I run `curl -sS http://localhost:8182/wp-login.php`
Then STDOUT should contain:
"""
wp-login.php
"""

Scenario: Pretty permalinks
Given a WP install
And I launch in the background `wp server --host=localhost --port=8183`
And I run `wp option update permalink_structure '/%postname%/'`

When I run `curl -sS http://localhost:8183/?p=1`
Then STDOUT should contain:
"""
Hello world!
"""
Comment on lines +32 to +38
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The scenario is named "Pretty permalinks", but the test uses curl ... /?p=1, which is a plain permalink. This doesn't fully validate that pretty permalinks are working as intended with the new router logic for non-existent files.

To make this test more robust and accurately reflect its name, I suggest testing an actual pretty URL like /hello-world/. This will require flushing the rewrite rules after setting the permalink structure. Using curl -L is also recommended to follow any potential redirects.

    And I run `wp option update permalink_structure '/%postname%/'`
    And I run `wp rewrite flush`

    When I run `curl -sSL http://localhost:8183/hello-world/`
    Then STDOUT should contain:
      """
      Hello world!
      """

Copy link
Member

@swissspidy swissspidy Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply feedback from this feedback

13 changes: 12 additions & 1 deletion router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,24 @@ function ( $url ) {
exit;
}

if ( strpos( $wpcli_server_path, '.php' ) !== false ) {
// Check if this is a PHP file by examining the extension
if ( pathinfo( $wpcli_server_path, PATHINFO_EXTENSION ) === 'php' ) {
// Set $_SERVER variables to mimic direct access to the PHP file
$_SERVER['SCRIPT_NAME'] = $wpcli_server_path;
$_SERVER['PHP_SELF'] = $wpcli_server_path;
$_SERVER['SCRIPT_FILENAME'] = $wpcli_server_root . $wpcli_server_path;

chdir( dirname( $wpcli_server_root . $wpcli_server_path ) );
require_once $wpcli_server_root . $wpcli_server_path;
} else {
return false;
}
} else {
// File doesn't exist - route to index.php for pretty permalinks
$_SERVER['SCRIPT_NAME'] = '/index.php';
$_SERVER['PHP_SELF'] = '/index.php';
$_SERVER['SCRIPT_FILENAME'] = $wpcli_server_root . '/index.php';

chdir( $wpcli_server_root );
require_once 'index.php';
}
Loading