Skip to content

Add validation for ref variable in install-wp-tests.sh #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Jan 20, 2026
Merged

Add validation for ref variable in install-wp-tests.sh #361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
001c47c
Initial plan
Copilot Jan 20, 2026
8f7c499
Add validation for ref variable to prevent undefined usage
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions templates/install-wp-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ install_test_suite() {
archive_url="https://github.com/WordPress/wordpress-develop/archive/refs/tags/${ref}.tar.gz"
fi

if [ -z "$ref" ]; then
echo -e "${RED}Error:${RESET} Unable to determine git reference from WP_TESTS_TAG: $WP_TESTS_TAG"
exit 1
fi

download "${archive_url}" "$TMPDIR/wordpress-develop.tar.gz"

# Validate that the tarball was downloaded correctly before extracting
Expand Down Expand Up @@ -201,6 +206,12 @@ install_test_suite() {
else
ref=${WP_TESTS_TAG#tags/}
fi

if [ -z "$ref" ]; then
echo -e "${RED}Error:${RESET} Unable to determine git reference from WP_TESTS_TAG: $WP_TESTS_TAG"
exit 1
fi

download https://raw.githubusercontent.com/WordPress/wordpress-develop/${ref}/wp-tests-config-sample.php "$WP_TESTS_DIR"/wp-tests-config.php
# remove all forward slashes in the end
WP_CORE_DIR=$(echo $WP_CORE_DIR | sed "s:/\+$::")
Expand Down
Loading