Skip to content

Add --actual flag to show database version from options table in multisite #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+164 −9
Draft

Add --actual flag to show database version from options table in multisite #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
877b8ce
Initial plan
Copilot Feb 2, 2026
6058af0
Add --actual flag to wp core version command for multisite db version…
Copilot Feb 2, 2026
0d519df
Address code review feedback: fix command args escaping and rename su…
Copilot Feb 2, 2026
2e05531
Refactor: extract TinyMCE version formatting and improve PHPDoc
Copilot Feb 2, 2026
eb2b614
Security: properly escape command arguments and improve PHPDoc type
Copilot Feb 2, 2026
3e67d56
Apply suggestions from code review
swissspidy Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"core multisite-install",
"core update",
"core update-db",
"core version"
"core version",
"core version-db-actual"
]
},
"autoload": {
Expand Down
70 changes: 70 additions & 0 deletions features/core-version.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,73 @@ Feature: Find version for WordPress install
TinyMCE version: 4.208 (4208-20151113)
Package language: de_DE
"""

# This test downgrades to an older WordPress version, but the SQLite plugin requires 6.0+
@require-mysql
Scenario: Verify actual database version shows correct values
Given a WP install
And I run `wp core download --version=6.6 --force`
And I run `wp option update db_version 45805`

# Without --actual, should show expected version from version.php
When I run `wp core version --extra`
Then STDOUT should contain:
"""
Database revision: 47018
"""

# With --actual, should show actual database version
When I run `wp core version --extra --actual`
Then STDOUT should contain:
"""
Database revision: 45805
"""

# This test downgrades to an older WordPress version, but the SQLite plugin requires 6.0+
@require-mysql
Scenario: Verify actual database version in multisite subsite
Given a WP multisite install
And I run `wp core download --version=6.6 --force`
And I run `wp option update db_version 47018`
And I run `wp site create --slug=subsite --porcelain`
And save STDOUT as {SUBSITE_ID}
And I run `wp option update db_version 45805 --url=example.com/subsite`

# Main site shows expected version from version.php without --actual
When I run `wp core version --extra`
Then STDOUT should contain:
"""
Database revision: 47018
"""

# Main site shows actual database version with --actual
When I run `wp core version --extra --actual`
Then STDOUT should contain:
"""
Database revision: 47018
"""

# Subsite shows expected version from version.php without --actual
When I run `wp core version --extra --url=example.com/subsite`
Then STDOUT should contain:
"""
Database revision: 47018
"""

# Subsite shows its own actual database version with --actual
When I run `wp core version --extra --actual --url=example.com/subsite`
Then STDOUT should contain:
"""
Database revision: 45805
"""

Scenario: Error when using --actual without --extra
Given a WP install

When I try `wp core version --actual`
Then STDERR should contain:
"""
Error: The --actual flag can only be used with --extra.
"""
And the return code should be 1

100 changes: 92 additions & 8 deletions src/Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,9 @@ private static function get_clean_basedomain() {
* [--extra]
* : Show extended version information.
*
* [--actual]
* : Show the actual database version from the database. This requires WordPress to be loaded and only works with --extra flag. Useful for checking the database version of a specific site in a multisite installation using --url.
*
* ## EXAMPLES
*
* # Display the WordPress version
Expand All @@ -916,23 +919,58 @@ private static function get_clean_basedomain() {
* TinyMCE version: 4.310 (4310-20160418)
* Package language: en_US
*
* # Display actual database version for a multisite subsite
* $ wp core version --extra --actual --url=example.com/subsite
* WordPress version: 4.5.2
* Database revision: 35700
* TinyMCE version: 4.310 (4310-20160418)
* Package language: en_US
*
* @when before_wp_load
*
* @param string[] $args Positional arguments. Unused.
* @param array{extra?: bool} $assoc_args Associative arguments.
* @param array{extra?: bool, actual?: bool} $assoc_args Associative arguments.
*/
public function version( $args = [], $assoc_args = [] ) {
$use_actual_db_version = Utils\get_flag_value( $assoc_args, 'actual' );

// If --actual flag is used, delegate to a command that runs after WP load
if ( $use_actual_db_version ) {
if ( ! Utils\get_flag_value( $assoc_args, 'extra' ) ) {
WP_CLI::error( 'The --actual flag can only be used with --extra.' );
}

// Build the command to run after WP load
$cmd_args = [];
foreach ( $assoc_args as $key => $value ) {
if ( 'actual' !== $key ) {
if ( true === $value ) {
$cmd_args[] = '--' . $key;
} elseif ( is_string( $value ) ) {
// Escape the value to prevent command injection
$cmd_args[] = '--' . $key . '=' . escapeshellarg( $value );
}
}
}
$cmd = 'core version-db-actual ' . implode( ' ', $cmd_args );

WP_CLI::runcommand(
$cmd,
[
'launch' => true,
'exit_error' => true,
]
);
return;
}

$details = self::get_wp_details();

if ( ! Utils\get_flag_value( $assoc_args, 'extra' ) ) {
WP_CLI::line( $details['wp_version'] );
return;
}

$match = [];
$found_version = preg_match( '/(\d)(\d+)-/', $details['tinymce_version'], $match );
$human_readable_tiny_mce = $found_version ? "{$match[1]}.{$match[2]}" : '';

echo Utils\mustache_render(
self::get_template_path( 'versions.mustache' ),
[
Expand All @@ -941,13 +979,59 @@ public function version( $args = [], $assoc_args = [] ) {
'local-package' => empty( $details['wp_local_package'] )
? 'en_US'
: $details['wp_local_package'],
'mce-version' => $human_readable_tiny_mce
? "{$human_readable_tiny_mce} ({$details['tinymce_version']})"
: $details['tinymce_version'],
'mce-version' => self::format_tinymce_version( $details['tinymce_version'] ),
]
);
}

/**
* Helper command to display actual database version (runs after WP load).
*
* This is an internal command called by 'core version --actual'.
*
* @subcommand version-db-actual
* @when after_wp_load
*
* @param string[] $args Positional arguments. Unused.
* @param array{extra?: bool} $assoc_args Associative arguments passed through from version command.
*/
public function version_db_actual( $args = [], $assoc_args = [] ) {
$details = self::get_wp_details();

// Get the actual database version from the options table
$actual_db_version = get_option( 'db_version' );

echo Utils\mustache_render(
self::get_template_path( 'versions.mustache' ),
[
'wp-version' => $details['wp_version'],
'db-version' => $actual_db_version,
'local-package' => empty( $details['wp_local_package'] )
? 'en_US'
: $details['wp_local_package'],
'mce-version' => self::format_tinymce_version( $details['tinymce_version'] ),
]
);
}

/**
* Formats the TinyMCE version for display.
*
* @param string $tinymce_version The TinyMCE version string.
* @return string Formatted TinyMCE version.
*/
private static function format_tinymce_version( $tinymce_version ) {
$match = [];
$found_version = preg_match( '/(\d)(\d+)-/', $tinymce_version, $match );
$human_readable_tiny_mce = $found_version ? "{$match[1]}.{$match[2]}" : '';

if ( $human_readable_tiny_mce ) {
return "{$human_readable_tiny_mce} ({$tinymce_version})";
}

return $tinymce_version;
}

/**
* Gets version information from `wp-includes/version.php`.
*
Expand Down
Loading