Revert 471 perf/first sumcheck round in base#479
Closed
BornPsych wants to merge 7 commits into
Closed
Conversation
Two #[ignore] probes for manual profiling: a size sweep (BF vs EF vs bn254, 2^14..2^20) and a 2^20 goldilocks-BF flamegraph + stage breakdown. Timing excludes scheme construction and harness clones (prove_setup builds inputs outside the timer; time_prove_core measures only commit + prove_noir), and the flame layer installs after fixture generation, so the numbers reflect the true prove core. Profiling-only deps (inferno, tracing-flame).
cargo fmt rewrapping of comments trimmed in earlier commits; no code change.
Round 1 of the Spartan sumcheck can consume base-field a, b, c directly (one mixed mul per point against the ext eq) instead of lifting them first; the fold at the first challenge does the lift. These helpers provide that round evaluation and fold, with parity against the existing fused ext path pinned by tests.
The witness bounds a, b, c were lifted to the extension before the sumcheck, paying ext arithmetic on base data for every round. The first round (half the sumcheck work) now consumes them directly — base products with one mixed mul per point against the ext eq — and the fold at the first challenge does the lift. Transcript values are unchanged (subfield arithmetic, same elements), so the verifier and proof format are untouched; bn254 rides the same path via Identity. ~5% prove @2^20 goldilocks-BF, no bn254 regression.
- prover: precompute 1/2 once and pass it into combined_round_message instead of recomputing a field inverse every round (transcript-identical) - deps: move inferno/tracing-flame to root [workspace.dependencies] - fixtures: relocate the single-commit timed prove into harness.rs and point the flamegraph probe at target/profile/
perf(prover): run the first sumcheck round in the base field
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CSP benchmarks
Prover time, peak RSS, peak heap, and verifier time are arithmetic means across the iterations. Peak heap comes from the largest Each metric cell shows the current value followed by the percentage delta against the latest successful Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #471 since the earlier base was with the #470 not with the main