[gjtorikian]

Summary

• stopBackgroundApp now finds every process in the app's group by reading /proc/<pid>/stat and signals each one: SIGTERM, up to five seconds for the group to empty, then SIGKILL. Where /proc is absent (a host runtime on macOS) it keeps the shell's negative-pid group kill.
• Root cause: the sandbox images run sh = dash, whose builtin kill rejects a negative pid with "Illegal number", so the group signal kill -TERM -- -<pgid> the harness has always sent failed and its fallback terminated only the group leader. Replaying the probe lifecycle inside quickstudy/workos-nextjs showed next dev and its start-server child still alive and bound to port 3000 thirty seconds after the stop; the next probe then booted on another port while the stale server answered the probe's requests.
• Seen in the hosted oracle run of the two-product authkit-webhooks eval (workos/evals#26, run 01M50M4XPG5KR3WKQ2WC4DY5HW): the Next.js attempt passed the login probe and answered 500 to every later probe, routes the stale server had never compiled. The consumer's waitForAppStopped waits 30 s for exactly this and then gives up; the harness should finish the job.
• Tests: the shell contract is pinned offline, and a behavioural case starts a TERM-ignoring process group and asserts it is gone after stop (runs where setsid exists, i.e. Linux and the sandbox images; skips on macOS). Verified in oven/bun:1.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with both previous test issues addressed.

Summary

stopBackgroundApp finds live group members through /proc, sends SIGTERM, waits up to five seconds, and sends SIGKILL to survivors.

• Probe shutdown now stops every process in the app’s group.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Read saved app PID] --> B{PID present?}
  B -->|No| C[Return]
  B -->|Yes| D[Send SIGTERM to group members]
  D --> E[Wait up to five seconds for live members]
  E --> F[Send SIGKILL to remaining members]

Loading

_{Reviews (3) · Last reviewed commit: "test(probe): clean up the stubborn group..." · Reviewed by Greptile}