Add selection mode and bulk actions to the V2 Media Library - #25944
Draft
crazytonyli wants to merge 3 commits into
Draft
Add selection mode and bulk actions to the V2 Media Library#25944crazytonyli wants to merge 3 commits into
crazytonyli wants to merge 3 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34026 | |
| Version | PR #25944 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 3488faf | |
| Installation URL | 43ifnq1sqm3f8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34026 | |
| Version | PR #25944 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 3488faf | |
| Installation URL | 774macnbvv408 |
Add the model layer for the V2 Media Library selection mode: selection state, bulk delete, and bulk share on MediaLibraryViewModel, with the bulk-share download owned by the view model so it survives the view leaving the window (e.g. a tab switch) rather than a view-lifetime task that a disappearance would silently cancel. Serialize loads so a cancelled, still-unwinding load can't strand the library half-loaded, and route every share-payload dismissal through a single cleanup chokepoint that releases temp files, including the swipe-dismiss path that never fires the activity controller's completion handler.
Add the selection-mode view layer for the V2 Media Library: a Select / Done navigation control, per-item selection badges, and a bottom selection bar (trash / count / share) rendered as a safe-area inset, since a UIHostingController pushed on a UIKit navigation controller drops .bottomBar toolbar items. Suppress the search field in selection mode without resetting the screen's identity by hanging the conditional .searchable off a zero-size background leaf, so toggling selection mode keeps grid scroll position and doesn't re-fire the load/observe/analytics tasks. Derive the minimized search-bar behavior from real UIKit containment via a host context the hosting controller writes, and end selection mode when the screen is popped.
crazytonyli
force-pushed
the
task/media-v2-selection-mode
branch
from
August 26, 2026 23:49
79b6f38 to
3488faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25943.