Skip to content

Announce selected post categories to VoiceOver #25893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitraj2203 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+14 −2
Open

Announce selected post categories to VoiceOver #25893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* [*] Custom Post Types: Make custom post types with REST API and editor support available in My Site [#25849]
* [*] Stop the media picker from removing gallery images when you cancel it in the experimental editor [#25866]
* [*] Stats: Fix the screen getting stuck on a loading indicator for self-hosted sites that are not connected to Jetpack [#25858]
* [*] Accessibility: VoiceOver now announces which post categories are selected [#25737]

27.1
-----
Expand Down
15 changes: 13 additions & 2 deletions WordPress/Classes/ViewRelated/Post/Categories/PostCategoriesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,20 @@ import WordPressUI
let indentationLevel = categoryIndentationDict[category.categoryID.intValue]
cell.indentationLevel = indentationLevel ?? 0
cell.indentationWidth = Constants.categoryCellIndentation
cell.textLabel?.text = category.categoryName.stringByDecodingXMLCharacters()
let title = category.categoryName.stringByDecodingXMLCharacters()
cell.textLabel?.text = title
WPStyleGuide.configureTableViewCell(cell)
cell.accessoryView = makeAccessoryView(isSelected: selectedCategories.contains(category))

let isSelected = selectedCategories.contains(category)
cell.accessoryView = makeAccessoryView(isSelected: isSelected)

// The checkmark is drawn in an image view, which carries no accessibility
// information, so selected and unselected rows were indistinguishable.
// Make the cell a single element and let the trait carry the state, rather
// than appending "selected" to the label.
cell.isAccessibilityElement = true
cell.accessibilityLabel = title
cell.accessibilityTraits = isSelected ? [.selected] : []

@crazytonyli crazytonyli Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "no category" cell (see configureNoCategoryRow) reuses the same cell instances, which need to be updated in the same way as here too.

@crazytonyli crazytonyli Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think you'd need to update the "didSelectRow" function, too? didSelectRow only updates accessoryView, but not the accessibility data.

I think it may make sense to have one single function for updating accessibility based on the cell state?

}

private func makeAccessoryView(isSelected: Bool) -> UIView {
Expand Down