[DO NOT MERGE] Validate the signing config for #23261 - #23266
Closed
mokagio wants to merge 1 commit into
Closed
Conversation
[DO NOT MERGE] Throwaway validation for #23261, closed once it has answered. Nothing in the PR pipeline exercises release signing: prototype builds assemble the `Debug` build type, lint and the manifest diffs never sign, and `release-builds.yml` and `beta-builds.yml` are API-triggered from release automation and check out a release branch rather than the PR. The first run that would notice a broken release signing config is the scheduled trunk-internal build, after merge. The debug side is worse than uncovered: when the shared keystore is absent AGP falls back to `~/.android/debug.keystore` and the build still goes green, so every prototype build so far has passed without proving the renamed `debug.keystore` was ever read. Both negative cases run against a throwaway `user.home` holding symlinks to the real credentials, so the agent's secrets directory is never mutated and no decrypted secret is copied anywhere. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Code Opus 5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
5 tasks
Contributor
Author
|
Answered: the release signing config resolves to the out-of-repo keystore on a Buildkite agent, and both negative cases confirm the file-existence gate is what produces that result. Evidence moved into #23261's description. Closing without merging, as intended. Posted by Claude (Opus 5) on behalf of @mokagio with approval. |
Contributor
|
|
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Validation only — do not merge. Stacked on
ainfra-2968-adopt-the-out-of-repo-keystore-convention-in-wordpress(#23261) so the step runs against exactly the code under review. It is closed once it has answered.Why the PR pipeline can't answer this
#23261 changes where the release signing config finds its keystore, and nothing on a PR exercises that path:
PROTOTYPE_BUILD_TYPE = 'Debug'.release-builds.ymlandbeta-builds.ymlare API-triggered from release automation andcheckout_release_branch, so they never see a PR's code.The first run that would notice is the scheduled trunk-internal build — after merge.
The debug side is worse than uncovered. When the shared keystore is missing, AGP falls back to
~/.android/debug.keystoreand the build stays green, so a passing prototype build has never been evidence that the renameddebug.keystorewas read.What to read
One job: 🔐 Validate signing config. Every step is expected to pass; there is no intentional failure here. It fails the build on any unmet assertion, and the three
signingReportoutputs are attached as artifacts.What each assertion proves
configure_applyon a Buildkite agent writes both keystores into the out-of-repo secrets directory under their new names.wordpressReleaseandjetpackReleasereportConfig: releasewithStore:pointing at that directory, and print a certificate — so path, store password and key alias all resolve on CI.wordpressDebugandjetpackDebugread the renameddebug.keystorerather than falling back.Config: none— the keystore file is what gates signing, so assertion 2 could have gone red.~/.android/debug.keystore— the failure mode assertion 3 exists to catch.Both negative cases run against a throwaway
user.homeholding symlinks to the real credentials, so the agent's secrets directory is never mutated and no decrypted secret is copied anywhere. EachsigningReportruns with--no-configuration-cache, sincesigningConfigs {}is evaluated at configuration time and a reused cache entry would let the negative cases pass without re-reading the disk.What this still doesn't answer
That AGP can sign and upload a real bundle with this keystore —
signingReportproves the config resolves, not thatbundleReleaseships. That first happens on the trunk-internal build, which notifies#build-and-ship.Opened by Claude (Opus 5) on behalf of @mokagio with approval.