Fix dashboard loading message state reset - #23254
Open
Manoj19636 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20411
Fixes an issue where the dashboard could incorrectly show the "No cards" message while clearing dashboard card states.
The
PersonalizeCardViewModelSlicestate is used to determine whether the dashboard should be displayed. Previously, the personalize card value was cleared after other card states, which could leave the dashboard in an incorrect intermediate state.This change moves
personalizeCardViewModelSlice.clearValue()to the beginning ofclearValue()so all dependent card states are reset in the correct order.Testing instructions
Test case title: Verify dashboard loading state reset
Test case title: Unit test verification
./gradlew :WordPress:testWordPressDebugUnitTest --tests "*DashboardCardsViewModelSliceTest"