Fix Me tab Gravatar icon not updating on first launch#23103
Open
thirumani-vihaan wants to merge 3 commits into
Open
Fix Me tab Gravatar icon not updating on first launch#23103thirumani-vihaan wants to merge 3 commits into
thirumani-vihaan wants to merge 3 commits into
Conversation
5193f5b to
6c9999a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #21415
On the very first launch (after a fresh app install and login), the Gravatar icon in the bottom navigation "Me" tab does not appear immediately. It requires a hard restart of the app to become visible.
This happens because the
accountrecord syncs asynchronously. By the timeWPMainNavigationViewis initialized, theavatarUrlmight not be available yet. AnonAccountChangedevent fires inWPMainActivityonce the user's account data successfully loads, but the bottom navigation view was never instructed to refresh its Gravatar icon dynamically.Changes made:
refreshGravatar()method toWPMainNavigationView.ktthat fetches the "Me" tabImageViewand safely updates it vialoadGravatar()using the latestaccountStore.account?.avatarUrl.WPMainActivity.javainsideonAccountChangedto invokemBottomNav.refreshGravatar()when an updated account event is broadcasted.Testing instructions
Fresh Install First-Run Avatar Load: