RS Post Settings: Device gallery as featured image source#22690
Draft
nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
Draft
RS Post Settings: Device gallery as featured image source#22690nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
Conversation
Allow choosing a featured image from the device gallery in addition to the WP Media Library. Device picks are copied to a temp file and uploaded via the wordpress-rs media API before being set as the featured image. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e options Replace the single "Change" menu item with "Choose from WP Media" and "Choose from device" options in the featured image dropdown. The placeholder (no image set) now shows the same dropdown menu instead of jumping straight to the picker. Each option launches its own dedicated picker without confusing source-switching toolbars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
nbradbury
changed the base branch from
trunk
to
feature/rsposts-settings-performance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WordPress/src/main/java/org/wordpress/android/ui/postsrs/PostRsSettingsActivity.kt
Fixed
Show fixed
Hide fixed
WordPress/src/main/java/org/wordpress/android/ui/postsrs/PostRsSettingsViewModel.kt
Fixed
Show fixed
Hide fixed
Contributor
|
|
Contributor
|
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/rsposts-settings-performance #22690 +/- ##
========================================================================
- Coverage 37.61% 37.59% -0.03%
========================================================================
Files 2272 2272
Lines 118381 118454 +73
Branches 16367 16373 +6
========================================================================
+ Hits 44531 44532 +1
- Misses 70200 70272 +72
Partials 3650 3650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to pick a featured image from the device gallery (in addition to the existing WP Media Library option). When a device image is selected, it is uploaded to the site's media library and then set as the featured image.
Key changes:
MediaCreateParams, and sets the returned media ID as the featured imageTesting instructions
Featured image from WP Media:
Featured image from device:
Remove featured image:
featured.mp4