RS Post Settings: Add author search to author dialog#22689
Draft
nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
Draft
RS Post Settings: Add author search to author dialog#22689nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
nbradbury wants to merge 4 commits intofeature/rsposts-settings-performancefrom
Conversation
Add a debounced search field to the author selection dialog, matching the existing pattern used for category/tag term search. Also fixes author selection from index-based to ID-based to prevent incorrect selection when the list changes during search or load-more. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace itemsIndexed with items in AuthorDialog since the index was unused, and consolidate AUTHORS_PER_PAGE to a single constant in PostRsRestClient. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reset the search query, search flag, and cached author list on dismiss so reopening the dialog shows a fresh state instead of stale search results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The authorSearchQuery and isSearchingAuthors fields are already reset by onDismissDialog(), so clearing them again on open is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
|
nbradbury
changed the base branch from
trunk
to
feature/rsposts-settings-performance
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/rsposts-settings-performance #22689 +/- ##
========================================================================
- Coverage 37.61% 37.58% -0.03%
========================================================================
Files 2272 2272
Lines 118381 118491 +110
Branches 16367 16380 +13
========================================================================
+ Hits 44531 44538 +7
- Misses 70200 70302 +102
- Partials 3650 3651 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds author search functionality to the author selection dialog on the RS Post Settings screen.
AUTHORS_PER_PAGEconstant (single source of truth inPostRsRestClient), replaceditemsIndexedwithitemswhere the index was unused, and removed redundant state clearing.Testing instructions
Author search:
author.mp4