fix(dashboard): improve budget usage chart dots#198
Open
siisee11 wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
onequery-landing | 2bdbaeb | Commit Preview URL Branch Preview URL |
May 11 2026, 04:32 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Line Summary
Budget Usage graph dots stay circular and show exact usage values on hover or keyboard focus.
User-Facing Changes
Budget Usagegraph dots no longer stretch horizontally when the chart container is wide.Why This Changed
The previous chart rendered the line, area, and dots inside an SVG with
preserveAspectRatio="none". That lets the chart fill the card, but it also scales SVG circles horizontally, making data points look distorted and leaving their exact values hidden.How It Changed
circleelements and into absolute-positionedbuttonoverlays so they keep a fixed circular shape.usagePercentandcumulativeSpendUsdto each chart point for tooltip andaria-labelcontent.apps/dashboard/src/features/budget/budget-dashboard-details.test.tsxto cover the accessible point value and tooltip text.Bug Fixes
Verification
bun run formatbun run lint -- apps/dashboard/src/features/budget/budget-dashboard-details.tsx apps/dashboard/src/features/budget/budget-dashboard-details.test.tsxbun run --cwd apps/dashboard test src/features/budget/budget-dashboard-details.test.tsxbun run --cwd apps/dashboard typecheckLEFTHOOK=0because the repository rootlint-fullhook currently fails withNo files found to lint; targeted lint/typecheck/test above passed.Video / Screenshot (Optional)