Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git-impactCLI surface with thin Cobra entrypoint wiring andanalyze/check-sourcescommand stubs.internal/gitimpactfoundations for types, config loading, and analysis-context construction../git-impactshim and initial tests for config, context, and command stub behavior.docs/exec-plans/active/todocs/exec-plans/completed/.Milestones completed
cmd/git-impact/main.gothin entrypoint intointernal/gitimpactwith command stubs.internal/gitimpact/types.gowith initial domain/config/result structs.internal/gitimpact/config.gousing Viper forimpact-analyzer.yamlload/decode with defaults.internal/gitimpact/context.gofor validatedAnalysisContextconstruction../git-impactexecutable shim.go.mod/go.sumfor Cobra + Viper and added scaffold tests.Key decisions
cmd/git-impactthin and moved behavior intointernal/gitimpactper architecture boundaries.analyzeandcheck-sourcesruntime logic as explicit stubs that return not-implemented errors after config/context validation.Test plan
GOCACHE=/tmp/go-build-cache go test ./...GOCACHE=/tmp/go-build-cache go build ./...