use heap hint with dilithium benchmark#9970
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dilithium benchmark to initialize keys with an explicit heap hint/device id, aligning it with APIs that support custom heap usage.
Changes:
- Switch Dilithium benchmark initialization from
wc_dilithium_inittowc_dilithium_init_exusingHEAP_HINTanddevId - Update the corresponding error message to reference the new init API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Retest this please Jenkins |
dgarske
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The was found when answering a direct email support question about ml-dsa with static memory. I tested with the configure
./configure --enable-mldsa --enable-mlkem --enable-staticmemory CPPFLAGS="-DBENCH_EMBEDDED -DWOLFSSL_NO_MALLOC -DWOLFMEM_DIST=49,10,6,14,5,6,16,1,1 -DWOLFMEM_BUCKETS=64,128,256,512,1024,2432,4096,8192,131072 -DWOLFSSL_DEBUG_MEMORY -DWOLFSSL_DEBUG_MEMORY_PRINT -DWOLFSSL_STATIC_MEMORY_TEST_SZ=200000" && make && ./wolfcrypt/benchmark/benchmark -ml-dsa