Split original ASN.1 code from asn.c into asn_orig.c#9920
Open
dgarske wants to merge 4 commits intowolfSSL:masterfrom
Open
Split original ASN.1 code from asn.c into asn_orig.c#9920dgarske wants to merge 4 commits intowolfSSL:masterfrom
dgarske wants to merge 4 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the non-template ASN.1 implementation into a separate asn_orig.c file and ensures it’s included in distributed source archives.
Changes:
- Adds the new
wolfcrypt/src/asn_orig.cfile to Automake’sEXTRA_DISTso it’s shipped in release tarballs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Jenkins retest this please |
Contributor
Author
|
Jenkins retest this please |
2 similar comments
Contributor
Author
|
Jenkins retest this please |
Contributor
Author
|
Jenkins retest this please |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Jenkins retest this please |
Contributor
Author
|
Jenkins retest this please - history lost |
LinuxJedi
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
Contributor
Author
|
Jenkins retest this please |
Move non-template (WOLFSSL_ASN_ORIGINAL) code into asn_orig.c and include from asn.c.
Add settings.h include before the compile guard in asn_orig.c so WOLFSSL_IGNORE_FILE_WARN is available when compiled separately. Add -Wno-pedantic for asn_orig.c in async examples Makefile to suppress empty translation unit warning.
Three fixes for guard-context correctness in the ASN.1 code split: 1. Strip WOLFSSL_ASN_ORIG_INCLUDED from forward declaration wrappers. The file-guard was being applied to fwd decls in asn.c, but at the fwd-decl site that macro is not yet defined, so #ifndef ... #else inverted the condition and hid all declarations. 2. Add outer feature guard tracking. Large feature sections (HAVE_OCSP, HAVE_CRL, WOLFSSL_CERT_GEN, etc.) that span many functions in asn.c are now tracked and re-emitted around the corresponding blocks in asn_orig.c, fixing 'unknown type name' errors in minimal builds. 3. Collect multi-line #if continuations in the outer guard map so that full guard conditions (e.g. #if !defined(NO_RSA) && \ continued across lines) are stored and compared as complete strings, preventing duplicate guard emission. Both modes build and pass tests (5 PASS, 0 FAIL each): ./configure --enable-asn=original && make check ./configure && make check
Forward declarations in asn.c and asn_orig.c now use guard transitions (same mechanism as the function bodies) so consecutive declarations with the same feature guard are grouped in a single #ifdef/#endif block rather than each having its own open/close pair. Also removed the now-redundant _find_func_outer_guards calls from _emit_split_body_orig; outer feature guard context is emitted at the generate_asn_orig loop level, not inside the per-block emitters. Both modes still build and pass tests (5 PASS, 0 FAIL each).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move non-template (
WOLFSSL_ASN_ORIGINAL) code intoasn_orig.cand include fromasn.c.