-
Notifications
You must be signed in to change notification settings - Fork 922
CMake fixes and improvements #9725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Jenkins retest this please |
|
It concerns me that this lists 373 checks having passed when other PR's have 411 checks and this PR should have added more tests with having a new .yml file. See for example (#9727) which was opened 14 hours ago. Could you rebase this onto the current wolfSSL master branch to see if it's just from being based on an older version of wolfSSL and missing some of the recent .yml additions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Minor fixes to the CMakeLists.txt * Add more options to the CMake infrastructure already present in the autoconf infrastructure * An autoconf build now also generates and installs files required to consume the installed wolfssl library via CMake. * Added test for autoconf-CMake interworking Work is mostly done by Codex and Curser.
|
Jenkins retest this please |
After rebasing to current master, there are now 389 tests. It appears that the Arduino tests didn't run, but idk why. |
|
I did not realize the Arduino GitHub Actions tests were set up this way, but they only trigger when files in specific paths are changed: So the 24 Arduino tests won't be ran, leading to only 389 tests ran. |
(Work has mostly been done using Codex and Curser).