Skip to content

Conversation

@Frauschi
Copy link
Contributor

  • An autoconf build now also generates and installs files required to consume the installed wolfssl library via CMake.
  • Added test for autoconf-CMake interworking
  • Minor fixes to CMakeLists.txt
  • Add more options to the CMake infrastructure already present in the autoconf infrastructure

(Work has mostly been done using Codex and Curser).

@Frauschi
Copy link
Contributor Author

Jenkins retest this please

@JacobBarthelmeh
Copy link
Contributor

It concerns me that this lists 373 checks having passed when other PR's have 411 checks and this PR should have added more tests with having a new .yml file. See for example (#9727) which was opened 14 hours ago. Could you rebase this onto the current wolfSSL master branch to see if it's just from being based on an older version of wolfSSL and missing some of the recent .yml additions?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Minor fixes to the CMakeLists.txt
* Add more options to the CMake infrastructure already present in the
  autoconf infrastructure
* An autoconf build now also generates and installs files required to
  consume the installed wolfssl library via CMake.
* Added test for autoconf-CMake interworking

Work is mostly done by Codex and Curser.
@Frauschi
Copy link
Contributor Author

Frauschi commented Feb 2, 2026

Jenkins retest this please

@Frauschi
Copy link
Contributor Author

Frauschi commented Feb 2, 2026

It concerns me that this lists 373 checks having passed when other PR's have 411 checks and this PR should have added more tests with having a new .yml file. See for example (#9727) which was opened 14 hours ago. Could you rebase this onto the current wolfSSL master branch to see if it's just from being based on an older version of wolfSSL and missing some of the recent .yml additions?

After rebasing to current master, there are now 389 tests. It appears that the Arduino tests didn't run, but idk why.

@Frauschi Frauschi assigned wolfSSL-Bot and unassigned Frauschi Feb 2, 2026
@JacobBarthelmeh
Copy link
Contributor

I did not realize the Arduino GitHub Actions tests were set up this way, but they only trigger when files in specific paths are changed:

    - IDE/ARDUINO/**                                                                                                    
    - src/**                                                                                                            
    - wolfcrypt/**                                                                                                      
    - wolfssl/**                                                                                                        
    - .github/workflows/arduino.yml

So the 24 Arduino tests won't be ran, leading to only 389 tests ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants