-
Notifications
You must be signed in to change notification settings - Fork 918
Add HMAC-BLAKE2b and HMAC-BLAKE2s API functions #9642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7ba4214 to
9249855
Compare
|
retest this please (org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-02zun3; wolf-linux-cloud-node-02zun3 was marked offline: Connection was broken) |
|
🛟 Devin Lifeguard found 2 likely issues in this PR
@holtrop-wolfssl |
@douzzer / @SparkiDev - I had mostly copied and adapted @douzzer's kernel implementation for this. But would it make sense to you two to fix either/both of these Devin suggestions? |
0df3878 to
edfb313
Compare
|
🛟 Devin Lifeguard found 2 likely issues in this PR
@holtrop-wolfssl |
edfb313 to
f8b01fe
Compare
f8b01fe to
b432ee9
Compare
| WOLFSSL_API int wc_Blake2bUpdate(Blake2b* b2b, const byte* data, word32 sz); | ||
| WOLFSSL_API int wc_Blake2bFinal(Blake2b* b2b, byte* final, word32 requestSz); | ||
| WOLFSSL_API int wc_Blake2bHmacInit(Blake2b * b2b, | ||
| const byte * key, size_t key_len); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention is * .
Also the convention in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "The convention is * ." mean? Are you asking for the space character before the "*" to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the important text got lost in the markup:
The convention is <type>* <name>.
Also the convention in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Ok, I will switch those. Should I also change the wc_InitBlake2b_WithKey() key parameter to match this as well for consistency or is it frowned upon to make stylistic-only changes to other preexisting lines?
Description
Add HMAC-BLAKE2b and HMAC-BLAKE2s API functions
Testing
Added unit tests with two KAT vectors for each HMAC-BLAKE2b and HMAC-BLAKE2s. Verified KAT vectors with both OpenSSL and Rust blake2 crate.
Checklist