Repository navigation
Compare physical paths in test data stamp and distclean rules - #12066
Open
julek-wolfssl wants to merge 1 commit into
Open
julek-wolfssl wants to merge 1 commit into
julek-wolfssl wants to merge 1 commit into
Conversation
Running configure as $(pwd -P)/./configure from a symlinked source dir makes abs_top_srcdir and abs_top_builddir differ as strings for an in-tree build. The stamp rule then deleted the real certs, input and quit and replaced each with a symlink to itself.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the physical-path comparison changes in test-data setup and cleanup.
No open issues 🎉
What changed in this PR
This PR prevents test-data deletion when an in-tree build uses a symlinked source directory by comparing physical source and build paths instead of their raw strings.
Changes:
- Use physical-path comparisons in the test-data stamp and
distcleanrules. - Update comments to explain why physical paths are required.
| File | Description |
|---|---|
Makefile.am |
Corrects in-tree build detection in test-data setup and cleanup to preserve source files. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configure is run as
$(pwd -P)/./configurefrom a symlinked source directory,abs_top_srcdirandabs_top_builddirdiffer as strings even for an in-tree build. The stamp rule then treated the build as out-of-tree and deleted the realcerts,inputandquit, replacing each with a symlink to itself.The stamp and distclean rules now compare physical paths instead of the raw strings, so an in-tree build is recognized correctly and the test data is left alone.