20260923-release-fixes - #11536
20260923-release-fixes#11536
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11536
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
|
…NG_WANT_BANKREF_SUPPORT as an explicit feature flag for the bankref mechanism, always disabled for FIPS configurations. wolfcrypt/src/random.c: allow WC_HAVE_RNG_BANKREF with HAVE_FIPS if WOLFSSL_FIPS_DEV. wolfssl/wolfcrypt/random.h: * remove WC_RNG_BANK_SUPPORT from the exclusion list for WC_RNG_LOCK_ATFORK * pivot WC_HAVE_RNG_BANKREF on WC_RNG_WANT_BANKREF_SUPPORT, with FIPS exclusion. wolfcrypt/src/rng_bank.c: update wc_InitRng_BankRef_local() and wc_BankRef_Release() to use WC_RNG_FLAG_BANKREF, not WC_DRBG_BANKREF. wolfssl/wolfcrypt/rng_bank.h: remove backward-compat clause defining WC_HAVE_RNG_BANKREF. linuxkm/lkcapi_rsa_glue.c: refactor km_rsa_ctx_init_rng() to check ctx->rng.flags, not ctx->rng.status, for bankref status. configure.ac: in ENABLED_RNG_BANK setup, split out WC_RNG_WANT_BANKREF_SUPPORT as a separate flag, and don't define it if FIPS. wolfcrypt/benchmark/fips_cast_bench.c: omit bench_pct_slhdsa() if defined(WOLFSSL_SLHDSA_VERIFY_ONLY). wolfcrypt/test/test.c: in myCryptoDevCb(), add HAVE_INTEL_RDRAND to list of macros enabling use of wc_RNG_GenerateBlock() for WC_ALGO_TYPE_RNG. linuxkm/Makefile: use bash-4.3-compatible syntax in $(()) expression. .wolfssl_known_macro_extras: remove unneeded entries.
32dafa9 to
103ef37
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11536
Scan targets checked: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11536
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11536
Scan targets checked: none
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
…K + WC_RNG_AUTOFORK support in autotools/cmake.
0d72286 to
cae706c
Compare
…in km_rsa_ctx_init_rng(). wolfcrypt/test/test.c: work around false positive cppcheck nullPointer warning in random_bank_test(). CMakeLists.txt, cmake/options.h.in: add WOLFSSL_SLHDSAVERIFYONLY.
|
retest this please |
…ility gate for the bankref identifier.
globally rename
WC_RNG_BANK_SUPPORTtoHAVE_WC_RNG_BANK, and addWC_RNG_WANT_BANKREF_SUPPORTas an explicit feature flag for the bankref mechanism, always disabled for FIPS configurations.wolfcrypt/test/test.c: inmyCryptoDevCb(), addHAVE_INTEL_RDRANDto list of macros enabling use ofwc_RNG_GenerateBlock()forWC_ALGO_TYPE_RNG.wolfcrypt/src/random.c: allowWC_HAVE_RNG_BANKREFwithHAVE_FIPSifWOLFSSL_FIPS_DEV.wolfssl/wolfcrypt/random.h:WC_RNG_BANK_SUPPORTfrom the exclusion list forWC_RNG_LOCK_ATFORKWC_HAVE_RNG_BANKREFonWC_RNG_WANT_BANKREF_SUPPORT.wolfcrypt/src/rng_bank.c: updatewc_InitRng_BankRef_local()andwc_BankRef_Release()to useWC_RNG_FLAG_BANKREF, notWC_DRBG_BANKREF.wolfssl/wolfcrypt/rng_bank.h: remove backward-compat clause definingWC_HAVE_RNG_BANKREF.linuxkm/lkcapi_rsa_glue.c: refactorkm_rsa_ctx_init_rng()to check ctx->rng.flags, not ctx->rng.status, for bankref status.configure.ac: inENABLED_RNG_BANKsetup, split outWC_RNG_WANT_BANKREF_SUPPORTas a separate flag, and don't define it if FIPS.wolfcrypt/benchmark/fips_cast_bench.c: omitbench_pct_slhdsa()ifdefined(WOLFSSL_SLHDSA_VERIFY_ONLY).linuxkm/Makefile: use bash-4.3-compatible syntax in$(())expression..wolfssl_known_macro_extras: remove unneeded entries.tested with
wolfssl-multi-test.sh ... super-quick-check