(d)tls13: implement session export feature - #11095
Draft
rizlik wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements session export/import support for TLS 1.3 and DTLS 1.3 by extending the serialized session format (new v7 chunks for TLS 1.3 traffic secrets / KeyUpdate state and DTLS 1.3 record-layer state), wiring DTLS export callbacks into the TLS 1.3 server accept path, and adding extensive API tests and CI coverage for round-trip, negative, and interoperability scenarios (including pre-v7 compatibility).
Changes:
- Bump session export format to version 7 and add serialized state chunks for (D)TLS 1.3.
- Add TLS 1.3 / DTLS 1.3 export/import test coverage (round-trip, KeyUpdate, replay window, negative cases, v6 compatibility).
- Add CI config job for
--enable-sessionexport=nopeerwith DTLS 1.3 enabled.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/internal.h | Updates export format constants, adds TLS13/DTLS13 chunk sizes, bumps export version to 7. |
| src/internal.c | Adds export/import of TLS 1.3 secrets/KeyUpdate state and DTLS 1.3 record-layer state; adds DTLS 1.3 export readiness guards. |
| src/tls13.c | Invokes DTLS export callback after DTLS 1.3 handshake completion (TLS 1.3 accept path). |
| tests/api/test_tls13.h | Registers new TLS 1.3 session export/import tests. |
| tests/api/test_tls13.c | Adds canned v6 import coverage and TLS 1.3 export/import + KeyUpdate tests. |
| tests/api/test_dtls13.h | Registers a new DTLS 1.3 session export/import test suite (macro list). |
| tests/api/test_dtls13.c | Adds DTLS 1.3 export/import round-trip, KeyUpdate, replay-window, negative, and callback tests. |
| tests/api/test_dtls.h | Registers additional DTLS session export/import compatibility tests. |
| tests/api/test_dtls.c | Adds canned v6 DTLS 1.2 import and DTLS 1.3 rejection of pre-v7 blobs tests. |
| doc/dox_comments/header_files/ssl.h | Documents new export/import behaviors and error returns for (D)TLS 1.3. |
| .github/configs/os-check-linux.json | Adds a CI configuration for --enable-sessionexport=nopeer with DTLS 1.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+100
to
+103
| TEST_DECL_GROUP("dtls13", test_dtls13_export_guards), \ | ||
| TEST_DECL_GROUP("dtls13", test_dtls13_export_import_roundtrip), \ | ||
| TEST_DECL_GROUP("dtls13", test_dtls13_import_negative), \ | ||
| TEST_DECL_GROUP("dtls13", test_dtls13_export_import_keyupdate), \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP