benchmark: fix: extends guards for algo that needs them - #11090
Draft
rizlik wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wolfcrypt/benchmark/benchmark.c preprocessor guards so that the benchmark’s RNG setup, asymmetric benchmark enablement, and stats/usage code are correctly compiled when additional post-quantum algorithms are enabled (notably Falcon and FrodoKEM, plus SLH-DSA/XMSS in non-verify-only builds).
Changes:
- Extend the
bench_desc_words/ related “needs RNG” guards to includeHAVE_FALCONandWOLFSSL_HAVE_FRODOKEM. - Expand
HAVE_LOCAL_RNG/BENCH_ASYM/bench_stats_asym_finish_exconditions to cover Falcon, FrodoKEM, and SLH-DSA/XMSS when signing/keygen code is present. - Update
Usage()output and CLI option matching guards to include FrodoKEM alongside other PQ asymmetric options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.