Open
Conversation
Many comment fixes, label renaming and non-functional changes. Bug Fixes x86_64 (aes_xts_asm.S/.asm) - Removed a spurious movl %edx, %eax that was clobbering a register, then fixed two comparisons to use %edx instead of the now-stale %eax. This was a functional bug in AES-XTS key-rounds selection. x86_64 (fe_x25519_asm.S) - Changed xor %rbx, %rbx → xorq %rbx, %rbx (explicit 64-bit operand size suffix). ARM32 (sp_arm32.c, sp_cortexm.c) - Fixed typo in assembly label names: sub_in_pkace → sub_in_place (both label definitions and branch targets). Affected 2048-bit and 3072-bit SP functions. - Fixed wrong source register in multiply/accumulate sequences: r11 → r7 and r3 → r4 (functional register-use bugs). ARM32 ChaCha (armv8-32-chacha-asm.S/_c.c) - Fixed label typo: same_keyb_ytes → same_key_bytes - Fixed NEON instruction syntax: vrev32.i16 → vrev32.16 (invalid mnemonic → correct ARM NEON form, affects multiple sites) ARM32 SHA3 (armv8-32-sha3-asm_c.c, .S) - Fixed symbol name typo: L_sha3_arm2_neon_rt / L_sha3_arm2_rt → L_sha3_arm32_neon_rt / L_sha3_arm32_rt ARM32 AES (armv8-32-aes-asm_c.c, thumb2-aes-asm_c.c, .S variants) - Fixed #endif comment: WOLFSSL_ARMASM_AES_BLOCK_INLINE → !WOLFSSL_ARMASM_AES_BLOCK_INLINE (logic inversion was missing from the comment) ARM64 ChaCha (armv8-chacha-asm_c.c/.S) - Fixed label typo: arm64loop_lt_8 → arm64_loop_lt_8 ARM32 ML-KEM (armv8-32-mlkem-asm.S/_c.c) - Fixed #endif comment typo: WOLFSLS_ARM_ARCH → WOLFSSL_ARM_ARCH (across many occurrences) SHA-512 (sha512_asm.S) - Corrected off-by-one in comments: msg_sched done: 0-3 → 0-1, 2-5 → 2-3, etc. (only 2 entries scheduled per block, not 4)
Contributor
Author
|
Code generated from PR: |
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many comment fixes, label renaming and non-functional changes.
Bug Fixes
x86_64 (aes_xts_asm.S/.asm)
fixed two comparisons to use %edx instead of the now-stale %eax. This was a
functional bug in AES-XTS key-rounds selection.
x86_64 (fe_x25519_asm.S)
suffix).
ARM32 (sp_arm32.c, sp_cortexm.c)
definitions and branch targets). Affected 2048-bit and 3072-bit SP functions.
r3 → r4 (functional register-use bugs).
ARM32 ChaCha (armv8-32-chacha-asm.S/_c.c)
correct ARM NEON form, affects multiple sites)
ARM32 SHA3 (armv8-32-sha3-asm_c.c, .S)
ARM32 AES (armv8-32-aes-asm_c.c, thumb2-aes-asm_c.c, .S variants)
ARM64 ChaCha (armv8-chacha-asm_c.c/.S)
ARM32 ML-KEM (armv8-32-mlkem-asm.S/_c.c)
occurrences)
SHA-512 (sha512_asm.S)
(only 2 entries scheduled per block, not 4)
Testing
Regression tested assembly code.