Cancel resumption if protocol changes#10015
Draft
rlm2002 wants to merge 1 commit intowolfSSL:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets
ssl->options.resuming = 0if downgrade occurs fromDoTls13ServerHello(). Necessary when attempted resumption with protocol from original connection is not accepted by server. Allows client to expect a full handshake.TLSv1.3 resumption downgrading to TLSv1.2 will fail after processing ServerHello as the client will expect incorrect message from server and will fail.
Testing
Modified
client-tis-resume.candserver-tis.cexample. After first connection usingwolfSSLv23_server_method(),server-tis.cwill create a new context that useswolfTLSv1_2_server_method()before receiving resumption ClientHello message.Checklist