F-13971: Ignore zero-length datagrams in DTLS demux server - #634
Open
julek-wolfssl wants to merge 1 commit into
Open
julek-wolfssl wants to merge 1 commit into
julek-wolfssl wants to merge 1 commit into
Conversation
recvfrom() returns 0 for an empty UDP datagram. The server treated that as fatal, so any peer could stop it with a single empty packet. Also retry EINTR/EAGAIN and report other receive errors.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates the DTLS demux server to ignore empty UDP datagrams and handle transient receive errors safely.
Changes:
- Retries interrupted or temporarily unavailable receives.
- Reports other
recvfrom()errors. - Ignores zero-length datagrams.
| File | Description |
|---|---|
dtls/server-dtls-demux.c |
Improves UDP receive error and empty-datagram handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recvfrom()returns 0 for an empty UDP datagram, which the server treated as fatal, allowing any peer to stop it with a single empty packet.EINTR/EAGAINare retried, and other receive errors are reported.