Add callbacks for additional channel requests. - #1146
Closed
blueshiftlabs wants to merge 1 commit into
Closed
Conversation
This adds and wires up callbacks for the following channel requests: - "signal" (RFC 4254 sec. 6.9) - "break" (RFC 4335; triggerable in openSSH client using ~B escape) - "env" (previously supported, but with no callback) In addition, expands unit tests to cover these newly-added callbacks, the previously-untested "subsystem" channel request, and adds extra verification that the proper callback is actually called.
|
Can one of the admins verify this patch? |
Member
|
Hi @blueshiftlabs , thank you for this code contribution. I've asked @ejohnstown to look this over (he's the primary maintainer). Can you tell us more about your project and use of wolfSSH? In order to accept this we need a signed contributor agreement. To get that setup please email support@wolfssl.com and provide your location and details about your project. |
Author
|
Hi David, My employer doesn't allow signing commercial CLAs, so I'll have to withdraw this pull request. If you have non-standard requirements for contributing code, could you please detail them in a CONTRIBUTING.md file in the repo so people know in advance? Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds and wires up callbacks for the following channel requests:
In addition, expands unit tests to cover these newly-added callbacks, the previously-untested "subsystem" channel request, and adds extra verification that the proper callback is actually called.