Fix ML-DSA example in docs - #143
Merged
Merged
Conversation
embhorn
requested review from
kojiws
and
a lite review from Copilot
and removed request for
Copilot
August 7, 2026 19:12
There was a problem hiding this comment.
Pull request overview
Updates the ML-DSA documentation examples to match the post–FIPS-204 API expectations around signing/verifying with an explicit context value.
Changes:
- Update ML-DSA signing example to pass
ctx=b"" - Update ML-DSA verification example to pass
ctx=b"" - Apply the same change to the export/import keys example
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example in doc was not updated after FIPS-204 changes