Skip to content

Enable more ruff rules requiring only minor or no fixes.#127

Open
roberthdevries wants to merge 2 commits into
wolfSSL:masterfrom
roberthdevries:enable-more-ruff-checks
Open

Enable more ruff rules requiring only minor or no fixes.#127
roberthdevries wants to merge 2 commits into
wolfSSL:masterfrom
roberthdevries:enable-more-ruff-checks

Conversation

@roberthdevries

Copy link
Copy Markdown
Contributor

Extra rules:
All E pycodestyle error rules
C4 flake8-comprehensions
DTZ flake8-datetimez
EXE flake8-executable
FA flake8-future-annotations
INT flake8-gettext
ISC flake8-implicit-str-concat
ICN flake8-import-conventions
LOG flake8-logging
G flake8-logging-format
RSE flake8-raise
SLOT flake8-slots
TID flake8-tidy-imports
TC flake8-type-checking
FLY flynt
PERF Perflint
W pycodestyle warnings
FURB refurb

Ignore E501: line too long

Extra rules:
All E pycodestyle error rules
C4   flake8-comprehensions
DTZ  flake8-datetimez
EXE  flake8-executable
FA   flake8-future-annotations
INT  flake8-gettext
ISC  flake8-implicit-str-concat
ICN  flake8-import-conventions
LOG  flake8-logging
G    flake8-logging-format
RSE  flake8-raise
SLOT flake8-slots
TID  flake8-tidy-imports
TC   flake8-type-checking
FLY  flynt
PERF Perflint
W    pycodestyle warnings
FURB refurb

Ignore E501:  line too long
@dgarske

dgarske commented Jun 22, 2026

Copy link
Copy Markdown
Member

Okay to test. Contributor agreement on file.

@dgarske dgarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skoll Code Review

Scan type: reviewOverall recommendation: COMMENT
Findings: 1 total — 1 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)

Posted findings

  • [Low] Stale comment above ruff select no longer matches the configurationpyproject.toml:99-103

Review generated by Skoll

Comment thread pyproject.toml Outdated
@@ -99,8 +99,8 @@ target-version = "py310"
# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 [Low] Stale comment above ruff select no longer matches the configuration

The comment block preceding select still reads: Enable Pyflakes (F) and a subset of the pycodestyle (E) codes by default. Unlike Flake8, Ruff doesn't enable pycodestyle warnings (W).... After this change, select now enables the full E family (not 'a subset') and explicitly enables pycodestyle warnings W, so the comment now contradicts the actual config. This is left over from the previous select = ["E4", "E7", "E9", ...] line and could mislead a future reader.

Fix: Update the comment to reflect that the full E and W families are now enabled, or drop the now-inaccurate sentence. Non-blocking.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the now obsolete comment block.

@dgarske dgarske removed their assignment Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants