Make native wolfCrypt the default crypto engine and wolfHSM optional - #17
Open
aidangarske wants to merge 9 commits into
Open
aidangarske wants to merge 9 commits into
aidangarske wants to merge 9 commits into
Conversation
aidangarske
requested review from
wolfSSL-Fenrir-bot
and
a lite review from Copilot
September 21, 2026 21:45
wolfSSL-Fenrir-bot
previously requested changes
Sep 21, 2026
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #17
Scan targets checked: wolftrust-src, wolftrust-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
aidangarske
force-pushed
the
native-crypto-fixes
branch
from
September 21, 2026 22:33
c45eaf1 to
7de5edf
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #17
Scan targets checked: wolftrust-src, wolftrust-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
wolfSSL-Fenrir-bot
dismissed
their stale review
September 21, 2026 22:47
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
aidangarske
force-pushed
the
native-crypto-fixes
branch
from
September 22, 2026 15:41
7de5edf to
b41db67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native wolfCrypt secure crypto engine, selected by WT_ENGINE=native (new default); WT_ENGINE=hsm links the wolfHSM server as an opt-in add-on. It uses Identical Non-secure to Secure boundary in both engines: same five CMSE FF-M veneers, service IDs, generated manifest, and L3 isolation bands.
ID, or manifest changes.
silicon native positive, restart, crossdomain, and FF-M conformance; skoll review and review-security clean; host make test
including new native_wire and native_wire_client suites.
-Os)