Skip to content

Update wolfHSM pin for STM32H5 flash support - #11

Closed
aidangarske wants to merge 2 commits into
wolfSSL:mainfrom
aidangarske:fix/wolfhsm-v1.5-autopin
Closed

aidangarske wants to merge 2 commits into
wolfSSL:mainfrom
aidangarske:fix/wolfhsm-v1.5-autopin

Conversation

@aidangarske

@aidangarske aidangarske commented Sep 19, 2026

Copy link
Copy Markdown
Member
  • Update wolfHSM to the tested v1.5-based PR commit for STM32H5 16-byte flash programming, with the wolfTrust integration changes it requires.
  • Update the wolfSSL pin and compatibility glue used by the same host and target builds.
  • Keep auto-pin updates release-based; the workflow will not replace this newer PR pin with an older tag.

Dependency / before merge

Copilot AI lite review requested due to automatic review settings September 19, 2026 03:21
@aidangarske aidangarske added the ci:all Run M33MU all on the PR branch label Sep 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The shared STM32H563 glue assigns client ID 1 to both HSM guests, while the auto-pin guard uses a non-upstream commit and can freeze dependency updates.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 2 Medium severity

Open (3)
What changed in this PR

Updates wolfHSM/wolfSSL integration for STM32H5 16-byte flash programming and adjusts client initialization, secure build configuration, and dependency pinning.

Changes:

  • Removes redundant crypto-callback registration and assigns client IDs.
  • Adds 16-byte flash and freestanding build support.
  • Improves attestation response validation and auto-pin safeguards.
File Description
tests/​host/​wolfhsm_loopback/​test_loopback.c Relies on wolfHSM client auto-registration.
tests/​host/​psa_ffm_client/​Makefile Adds math source dependencies.
tests/​host/​ffm_veneer/​Makefile Adds math source dependencies.
tests/​host/​attestation_iak/​main.c Uses configured flash page size.
tests/​firmware/​zephyr-stm32h5/​scripts/​build_freertos_guest.sh Sets guest client ID.
tests/​firmware/​zephyr-stm32h5/​module/​wolfhsm-client/​src/​wolfhsm_zephyr_init.c Updates client initialization.
tests/​firmware/​zephyr-stm32h5/​module/​wolfhsm-client/​src/​wolfhsm_client_glue.c Adds configurable client IDs.
tests/​firmware/​zephyr-stm32h5/​apps/​freertos_guest1/​main.c Removes manual callback registration.
tests/​firmware/​stm32h563/​nonsecure/​wolfhsm_client_glue.c Updates the guest client namespace.
src/​services/​wolfhsm/​wt_hsm.c Validates key-generation response length.
src/​services/​wolfhsm/​runner/​wh_settings_local.h Enables 16-byte flash units and disables logging.
src/​services/​wolfhsm/​runner/​user_settings.h Adds freestanding wolfCrypt settings.
src/​services/​wolfhsm/​runner/​libc_stubs.h Declares libc stubs.
mk/​common.mk Adds wolfCrypt memory support.
.github/​workflows/​auto-pin-dependencies.yml Preserves required dependency history.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/firmware/stm32h563/nonsecure/wolfhsm_client_glue.c Outdated
Comment thread .github/workflows/auto-pin-dependencies.yml Outdated
Comment thread tests/host/attestation_iak/main.c
Use separate wolfHSM client IDs for the two bare-metal guests and adapt the cross-namespace probe to the pinned receive API. Exercise the IAK host suite with both 8-byte and 16-byte flash units, and keep auto-pin releases gated on the temporary wolfHSM PR commit.
@aidangarske aidangarske added ci:all Run M33MU all on the PR branch and removed ci:all Run M33MU all on the PR branch labels Sep 19, 2026
@aidangarske
aidangarske marked this pull request as ready for review September 19, 2026 03:54
@aidangarske
aidangarske requested review from wolfSSL-Fenrir-bot and a lite review from Copilot September 21, 2026 15:28
@aidangarske aidangarske self-assigned this Sep 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Medium severity

Open (1)
Resolved since last review (3)

Comment on lines +42 to +43
LOG_ERR("wolfhsm_guest_init failed rc=%d", rc);
return rc;
@aidangarske

Copy link
Copy Markdown
Member Author

Have to close since the repo went to public and merge base is invalid now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants