Repository navigation
Fix build-release nightly job by removing examples object files - #528
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change excluding the examples directory from release archives.
No open issues 🎉
What changed in this PR
This PR fixes the nightly release build by preventing generated example object files from being bundled into the source tarball, where they can disrupt out-of-tree linking.
Changes:
- Removes
examplesfromEXTRA_DISTso the entire directory is no longer copied into release archives.
| File | Description |
|---|---|
Makefile.am |
Removes blanket distribution of the examples directory to avoid packaging build artifacts. |
Review effort: Balanced
aidangarske
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this error observed in Jenkins:
EXTRA_DIST+=examplesfrom Makefile.am copied the wholeexamples/dir into the tarball, includingexamples/openssl_example.o. Upon unpacking it, the .o is in the srcdir and is not rebuilt, and fails to link because the .o files are not expected to be in srcdir.