Optimize FIPS CAST startup tests #351
Conversation
…ead safe lazy CAST
…_fips_cast_optimization
|
jenkins retest this please |
| #define WP_CHECK_FIPS_ALGO(algo) \ | ||
| do { \ | ||
| if (wp_init_cast(algo) != 1) { \ | ||
| WOLFPROV_ERROR_MSG(WP_LOG_COMP_PROVIDER, \ |
There was a problem hiding this comment.
There could be a code size hit due to the frequency of these macros (mainly from duplicate logs). Is that ok?
Could convert to functions I suppose, but might make the caller size a bit less clean.
There was a problem hiding this comment.
Or just move the log into wp_init_cast
| /* Dispatch to algorithm-specific inner function */ | ||
| switch (algo) { | ||
| #ifdef WP_HAVE_AES | ||
| case WP_CAST_ALGO_AES: |
There was a problem hiding this comment.
The indentation looks off in this switch
| } | ||
|
|
||
| if (castAlgos[algo].init == 0) { | ||
| if (wp_lock(wp_get_cast_mutex(algo)) != 1) { |
There was a problem hiding this comment.
wp_get_cast_mutex is only called from this function, and this function already indexes into castAlgos[algo]. I'd say to use castAlgos[algo].mutex directly here.
| * @return Initialization state (0 = not initialized, 1 = initialized). | ||
| * @return 0 if algo is out of range. | ||
| */ | ||
| int wp_get_cast_init(int algo) |
There was a problem hiding this comment.
This function doesn't appear to be called
| * @param [in] algo Algorithm category (WP_CAST_ALGO_*). | ||
| * @param [in] init Initialization state to set. | ||
| */ | ||
| void wp_set_cast_init(int algo, int init) |
There was a problem hiding this comment.
Also seemingly not called
| * @return 1 on success. | ||
| * @return 0 on failure. | ||
| */ | ||
| static int wp_rsa_init_cast_inner(void) |
There was a problem hiding this comment.
Why all the wrapper functions? Can we do the calls to wc_RunCast_* directly in the switch?
2 participants
Optimize FIPS CAST startup tests with per algo mutex handling for thread safe lazy CAST.