SHA-3: zeroize working buffers - #525
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
assigned
padelsbach and
AlexLanzano and unassigned
padelsbach and
AlexLanzano
Member
|
Are there any performance implications from this change? Im not entirely convinced that the client needs to zeroize these buffers. |
Contributor
Author
According to a few benchmark runs, performance impact is < 0.5%, with all the other copying going on. However, there's not much of a precedent of zeroing hash contents. WolfCrypt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8510: wipe the intermediate buffers in SHA3 client side.
Found during SHAKE dev in PR #523