Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The identifier behavior lacks a regression assertion and leaves contradictory matching guidance in vendored comments.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates SBOM generation to treat nested wolfcrypt as provenance-only while retaining wolfSSL CPE matching.
Changes:
- Removes wolfcrypt CPEs from CycloneDX and SPDX output.
- Requires wolfcrypt PURLs in validation and updates documentation.
- Re-vendors wolfGlass at
3b708daand bumps generator version to 1.9.
File summaries
| File | Description |
|---|---|
tools/sbom/validate_sbom.py |
Accepts wolfcrypt with PURL but no CPE. |
tools/sbom/gen-sbom |
Omits nested wolfcrypt CPEs. |
tools/sbom/build/sbom.mk |
Updates Make integration documentation. |
tools/sbom/build/sbom.cmake |
Updates CMake integration documentation. |
tools/sbom/.wolfglass-rev |
Updates wolfGlass revision pin. |
Makefile |
Documents wolfSSL CPE matching. |
docs/SBOM.md |
Documents identifier semantics. |
Review details
Suppressed comments (1)
tools/sbom/gen-sbom:1086
- The new conditional is the behavior this PR changes, but the SBOM workflow only performs structural validation and never asserts the identifier set. A future vendor sync could re-add the nested wolfcrypt CPE (or drop the parent wolfssl CPE) while the current checks remain green; add a focused generated-SBOM assertion for both documents.
# wolfcrypt has no CPE: matching rides on the parent wolfssl CPE.
if meta.get('cpe'):
comp['cpe'] = meta['cpe'](version)
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Re-vendor wolfGlass at 3b708da. wolfcrypt stays a nested component (name, version, PURL). Matching uses the wolfssl CPE only. Co-authored-by: Cursor <cursoragent@cursor.com>
Makefile no longer says a scan matches wolfssl:wolfcrypt. Re-vendor wolfGlass at 48796ea so the generator contract exempts nested wolfcrypt. Co-authored-by: Cursor <cursoragent@cursor.com>
sameehj
force-pushed
the
fix/sbom-drop-nested-wolfcrypt-cpe
branch
from
September 22, 2026 13:08
7b8c779 to
feef1fa
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #894
No scan targets match the changed files in this PR. Review skipped.
sameehj
force-pushed
the
fix/sbom-drop-nested-wolfcrypt-cpe
branch
from
September 22, 2026 13:40
feef1fa to
743c11e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
224a4f3(wolfGlass Fixes for external SPI build option "SPI_FLASH=1" #29, on master).#wolfcrypt). No wolfcrypt CPE.cpe:2.3:a:wolfssl:wolfssl:<version>.Test plan
make sbom TARGET=sim— nested wolfcrypt has PURL, nocpecpe:2.3:a:wolfssl:wolfssl:<version>224a4f3