Skip to content

Allow use of presets (physical button) when receiving live data #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsaccoBenedetti wants to merge 7 commits into
base: main
Choose a base branch
from
+9 −8
Open

Allow use of presets (physical button) when receiving live data #5370

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7dda58
ignore realtime
IsaccoBenedetti Feb 10, 2026
656a743
Fix tested
IsaccoBenedetti Feb 10, 2026
8f77932
Fix: Realtime override deadlock and RD API support
IsaccoBenedetti Feb 11, 2026
817ce1c
build flags
IsaccoBenedetti Feb 11, 2026
cbddd38
removing debug files
IsaccoBenedetti Feb 11, 2026
34c7dd8
Merge branch 'wled:main' into fix-unresponsive-buttons-when-receiving…
IsaccoBenedetti Feb 11, 2026
af31689
Clean up
IsaccoBenedetti Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions wled00/wled.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,14 @@ void WLED::loop()
#ifdef WLED_DEBUG
stripMillis = millis();
#endif

if (!presetNeedsSaving()) {
handlePlaylist();
yield();
}
handlePresets();
yield();

if (!realtimeMode || realtimeOverride || (realtimeMode && useMainSegmentOnly)) // block stuff if WARLS/Adalight is enabled
{
if (apActive) dnsServer.processNextRequest();
Expand All @@ -119,14 +127,7 @@ void WLED::loop()
handleHue();
yield();
#endif

if (!presetNeedsSaving()) {
handlePlaylist();
yield();
}
handlePresets();
Copy link
Member

@softhack007 softhack007 Feb 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to create an else branch for if (!realtimeMode ...., and put handlepresets() into the else branch. But I would still prefer this to be guarded by a user-controled settings.

yield();


if (!offMode || strip.isOffRefreshRequired() || strip.needsUpdate())
strip.service();
#ifdef ESP8266
Expand Down