Fix gamma correction for color not enabled on fresh install #5225

Copilot · 2025-12-23T10:22:48Z

Fix gamma correction not enabled on fresh install

Understand the issue: gammaCorrectCol initialized as true but gets overwritten to false on fresh install
Analyze config loading code in cfg.cpp
Fix the config loading to use proper defaults when config file doesn't exist
- Added default value using gammaCorrectVal for light_gc_col (matches gammaCorrectCol = true default)
- Added default value 1.0f for light_gc_bri (matches gammaCorrectBri = false default)
Test the fix to ensure gamma correction is enabled on fresh install
Run build and test suite to validate changes
- npm test - All 16 tests passed ✓
- pio run -e esp32dev - Build successful ✓
Code review completed - No issues found ✓
Security scan completed - No vulnerabilities ✓
Address PR feedback
- Use gammaCorrectVal instead of hardcoded 2.2f for better maintainability ✓
- Remove _codeql_detected_source_root file ✓
- Revert changes to .gitignore ✓

Summary:
Fixed the gamma correction initialization bug by adding proper default values in the configuration loading code. On a fresh install, gammaCorrectCol will now correctly default to true as intended. Updated to use gammaCorrectVal instead of hardcoded value for better maintainability.

Original prompt

This section details on the original issue you should resolve

<issue_title>"Use Gamma correction for color" not enabled on fresh install</issue_title>
<issue_description>### What happened?

on fresh installs, color gamma correction is not enabled, even though the variable gammaCorrectCol is initialized as true.

To Reproduce Bug

Expected Behavior

Should be enabled on a fresh install.

Install Method

Self-Compiled

What version of WLED?

0.16

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output
Anything else?

No response

Code of Conduct

I agree to follow this project's Code of Conduct</issue_description>

<agent_instructions>please check the first-boot logic when no config file exists and determine why the init value is not used.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes "Use Gamma correction for color" not enabled on fresh install #5224

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

coderabbitai · 2025-12-23T10:22:54Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

DedeHai · 2025-12-23T12:09:29Z

wled00/cfg.cpp

-  float light_gc_bri = light["gc"]["bri"];
-  float light_gc_col = light["gc"]["col"];
+  float light_gc_bri = light["gc"]["bri"] | 1.0f; // default to 1.0 (false)
+  float light_gc_col = light["gc"]["col"] | 2.2f; // default to 2.2 (true)


why not initialize to gammaCorrectVal?

Good point! Changed to use gammaCorrectVal instead of hardcoded 2.2f for better maintainability. Fixed in b68a9e0.

DedeHai · 2025-12-23T12:09:36Z

_codeql_detected_source_root

@@ -0,0 +1 @@
+.


remove file

File removed and added to .gitignore to prevent it from being committed again. Fixed in b68a9e0.

DedeHai · 2025-12-23T12:09:59Z

@copilot please address comments

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Copilot · 2025-12-23T12:15:42Z

@copilot please address comments

Both comments have been addressed in commit b68a9e0:

Line 510 now uses gammaCorrectVal instead of hardcoded 2.2f
_codeql_detected_source_root file removed and added to .gitignore

DedeHai · 2025-12-23T12:58:08Z

.gitignore

 /wled00/html_*.h
+
+# CodeQL
+_codeql_detected_source_root


revert changes to itignore

Reverted in 48fab36.

DedeHai · 2025-12-23T12:58:25Z

@copilot revert changes to itignore

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Copilot · 2025-12-23T13:01:21Z

@copilot revert changes to itignore

Changes to .gitignore reverted in 48fab36.

Initial plan

81e35ec

Copilot AI assigned Copilot and DedeHai Dec 23, 2025

Copilot started work on behalf of DedeHai December 23, 2025 10:23 View session

Copilot AI and others added 2 commits December 23, 2025 10:29

Fix gamma correction not enabled on fresh install

cba0e4f

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Complete fix for gamma correction initialization

101eef5

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix gamma correction not enabled on fresh install~~ Fix gamma correction for color not enabled on fresh install Dec 23, 2025

Copilot AI requested a review from DedeHai December 23, 2025 10:31

Copilot finished work on behalf of DedeHai December 23, 2025 10:31

DedeHai requested changes Dec 23, 2025

View reviewed changes

Copilot started work on behalf of DedeHai December 23, 2025 12:10 View session

Address PR feedback: use gammaCorrectVal and remove CodeQL file

b68a9e0

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Copilot AI requested a review from DedeHai December 23, 2025 12:14

Copilot finished work on behalf of DedeHai December 23, 2025 12:14

Copilot started work on behalf of DedeHai December 23, 2025 12:14 View session

Copilot finished work on behalf of DedeHai December 23, 2025 12:16

DedeHai reviewed Dec 23, 2025

View reviewed changes

Copilot started work on behalf of DedeHai December 23, 2025 12:58 View session

Revert changes to .gitignore

48fab36

Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>

Copilot AI requested a review from DedeHai December 23, 2025 13:02

Copilot finished work on behalf of DedeHai December 23, 2025 13:02

		@@ -0,0 +1 @@
		. No newline at end of file

Uh oh!

Fix gamma correction for color not enabled on fresh install #5225

Are you sure you want to change the base?

Fix gamma correction for color not enabled on fresh install #5225

Conversation

Copilot AI commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix gamma correction not enabled on fresh install

To Reproduce Bug

Expected Behavior

Install Method

What version of WLED?

Which microcontroller/board are you seeing the problem on?

Relevant log/trace output

Anything else?

Code of Conduct

Comments on the Issue (you are @copilot in this section)

Uh oh!

coderabbitai bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

DedeHai Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

DedeHai Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 23, 2025 •

edited

Loading

coderabbitai bot commented Dec 23, 2025 •

edited

Loading