Track the floating esp-web-tools@10 tag - #84
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018kfrZXtvjTzUL1gGTHGhVw
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughBoth installer pages update the ChangesInstaller module update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@auto.htm`:
- Line 13: Pin the esp-web-tools installer URL to an explicit immutable version
instead of the floating `@10` selector in auto.htm:13 and index.htm:13, keeping
both entry points on the same pinned artifact. If dependency updates are
intended, document and follow an approved release-management policy rather than
allowing runtime version changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d72658c2-c025-4c0d-a81a-33f24e9b3d60
📒 Files selected for processing (2)
auto.htmindex.htm
Mentioned by : wled#84
|
I personally dont like the floating version tag, as this opens the door to having a breaking change of ESPWebTools directly impact the functionality of the webinstaller. And it kinda opens the door to a supply chain attack. |
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Mentioned by : wled#84
The installer is pinned to
esp-web-tools@10.1.0. This switchesindex.htmandauto.htmto the floating@10tag so the installer picks up patch releases within v10 automatically (the current release is 10.4.0).Most of what you gain is on the Improv Wi-Fi side, in 10.3.0: the network picker keeps scanning while the form is open and merges results (so a network the first scan missed still shows up), each network shows signal strength, RSSI and whether it is secured, the strongest one is preselected, a device that reports the Improv stopped state now says so instead of leading the user through a form that cannot succeed, and Firefox is recognized as a supported WebSerial browser. 10.4.0 fixes a scan race and default-selection bug in that same picker.
10.3.0 also updates esptool-js to 0.6.0 and adds the optional
serialTypemanifest field for projects shipping separate CDC and UART builds.Summary by CodeRabbit