Skip to content

Track the floating esp-web-tools@10 tag - #84

Merged
lost-hope merged 2 commits into
wled:masterfrom
balloob:esp-web-tools-10
Aug 1, 2026
Merged

Track the floating esp-web-tools@10 tag#84
lost-hope merged 2 commits into
wled:masterfrom
balloob:esp-web-tools-10

Conversation

@balloob

@balloob balloob commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

The installer is pinned to esp-web-tools@10.1.0. This switches index.htm and auto.htm to the floating @10 tag so the installer picks up patch releases within v10 automatically (the current release is 10.4.0).

Most of what you gain is on the Improv Wi-Fi side, in 10.3.0: the network picker keeps scanning while the form is open and merges results (so a network the first scan missed still shows up), each network shows signal strength, RSSI and whether it is secured, the strongest one is preselected, a device that reports the Improv stopped state now says so instead of leading the user through a form that cannot succeed, and Firefox is recognized as a supported WebSerial browser. 10.4.0 fixes a scan race and default-selection bug in that same picker.

10.3.0 also updates esptool-js to 0.6.0 and adds the optional serialType manifest field for projects shipping separate CDC and UART builds.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the web installer to use ESP Web Tools 10.4.0, improving installation reliability and ensuring access to the latest stable installation experience.
    • Applied the update consistently across both automatic and interactive installation pages.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018kfrZXtvjTzUL1gGTHGhVw
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6efccd88-949f-42c6-8f5d-87429a3a1595

📥 Commits

Reviewing files that changed from the base of the PR and between 445a173 and 8e5bb27.

📒 Files selected for processing (2)
  • auto.htm
  • index.htm
🚧 Files skipped from review as they are similar to previous changes (2)
  • index.htm
  • auto.htm

Walkthrough

Both installer pages update the esp-web-tools install-button module URL from CDN version 10.1.0 to 10.4.0.

Changes

Installer module update

Layer / File(s) Summary
Update installer module sources
auto.htm, index.htm
The esp-web-tools module source changes from version 10.1.0 to 10.4.0 in both installer pages.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit checking URLs today,
Both installer pages hop the same way.
From 10.1.0 to 10.4.0,
The module paths now align,
And I nibble my review away.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating both pages to use the floating esp-web-tools@10 tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@auto.htm`:
- Line 13: Pin the esp-web-tools installer URL to an explicit immutable version
instead of the floating `@10` selector in auto.htm:13 and index.htm:13, keeping
both entry points on the same pinned artifact. If dependency updates are
intended, document and follow an approved release-management policy rather than
allowing runtime version changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d72658c2-c025-4c0d-a81a-33f24e9b3d60

📥 Commits

Reviewing files that changed from the base of the PR and between f809b04 and 445a173.

📒 Files selected for processing (2)
  • auto.htm
  • index.htm

Comment thread auto.htm Outdated
lost-hope added a commit to lost-hope/WLED-WebInstaller that referenced this pull request Jul 28, 2026
@lost-hope

lost-hope commented Jul 28, 2026

Copy link
Copy Markdown
Member

I personally dont like the floating version tag, as this opens the door to having a breaking change of ESPWebTools directly impact the functionality of the webinstaller. And it kinda opens the door to a supply chain attack.
What i will consider is to change the version to 10.4.0 directly.
that way we have the new fixes and still have a fixed version.

@lost-hope lost-hope left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to the latest version but keep it fixed. 10.4.0
reasoning as a comment in the PR
src="https://unpkg.com/esp-web-tools@10.4.0/dist/web/install-button.js?module"

Comment thread index.htm Outdated
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@lost-hope
lost-hope merged commit 0f79c7a into wled:master Aug 1, 2026
1 check passed
lost-hope added a commit to lost-hope/WLED-WebInstaller that referenced this pull request Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants