Feat(json_rpc): implement new method searchDataRequests #2656
+155
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HashMap will not be persisted to storage. Nodes must explicitly opt-in.
Tommytrg
reviewed
Sep 15, 2025
aesedepece
reviewed
Dec 2, 2025
Comment on lines
+1544
to
+1546
| let since_epoch: u32 = since_epoch.try_into().inspect_err(|&e| { | ||
| log::warn!("Invalid 'since' limit on SearchDataRequests: {e}"); | ||
| })?; |
Member
There was a problem hiding this comment.
Do we really want to fail silently here instead of returning the error?
Contributor
Author
There was a problem hiding this comment.
Wouldn't the ? on L1546 make the function return with an error Result?
Comment on lines
1540
to
1543
| let mut since_epoch: i64 = msg.since.unwrap_or_default(); | ||
| if let Some(current) = self.current_epoch { | ||
| since_epoch = i64::from(current).saturating_add(since_epoch); | ||
| } |
Member
There was a problem hiding this comment.
The logic here is:
- Use
sincefrom the arguments if provided, otherwise make it0 - Then if there's a current epoch (in practice, always), add current epoch to the
since_epochfrom before
As a result, for any given value of since greater than 0, you are guaranteed to get no results as you'd be looking for epochs in the future.
I'm assuming this logic is not correct.
Contributor
Author
There was a problem hiding this comment.
Indeed. A default -4320i64 was rather intended.
…archDataRequests message
aesedepece
approved these changes
Dec 3, 2025
Member
|
Merged as of e05b06f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.