WPB-26650 prevent fed state drift on prevent adminless groups actions - #5425
Open
battermann wants to merge 7 commits into
Open
WPB-26650 prevent fed state drift on prevent adminless groups actions#5425battermann wants to merge 7 commits into
battermann wants to merge 7 commits into
Conversation
battermann
marked this pull request as ready for review
August 6, 2026 12:10
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “preventAdminlessGroups” handling for federated conversations to avoid senderless system-triggered deletions (and reminders) when remote members are present, preventing remote/backend state drift. It also adds integration tests and documentation describing the new behavior.
Changes:
- Skip senderless adminless deletion/reminder paths for conversations that contain remote members, and log the skip.
- Add integration coverage for federated conversations around setup-time deletion/autopromotion behavior with remote members.
- Document the federated behavior caveats and add a changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/wire-subsystems/src/Wire/ConversationSubsystem/Update.hs | Adds the skip predicate + logging and applies it to setup deletion, deletion jobs, and reminder jobs. |
| integration/test/Test/AdminlessGroups.hs | Adds new integration scenarios for federated conversations with remote members (origin delete, skip senderless delete, autopromotion). |
| docs/src/developer/reference/config-options.md | Documents the federated skip behavior and rationale for deletion/reminders vs autopromotion. |
| changelog.d/2-features/WPB-26650 | Changelog entry describing the behavior change. |
Comment on lines
99
to
+101
| import Polysemy.TinyLog | ||
| import Polysemy.TinyLog qualified as P | ||
| import System.Logger qualified as Log |
Comment on lines
+1490
to
+1493
| orAlternativelySendReminder conv _ _ = | ||
| if shouldSkipSystemAdminlessDeletion mlusr conv | ||
| then logSkippedSystemAdminlessDeletion conv | ||
| else do |
|
|
||
| logSkippedSystemAdminlessDeletion :: (Member TinyLog r) => StoredConversation -> Sem r () | ||
| logSkippedSystemAdminlessDeletion conv = | ||
| P.info $ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d