fix(integration): use dedicated HTTP manager with managerIdleConnectionCount = 0 for probes - #5406
Open
blackheaven wants to merge 1 commit into
Conversation
…onCount = 0 for probes This commit configures a dedicated HTTP.Manager for probe requests with managerIdleConnectionCount = 0 to prevent connection pool pollution during startup. Background & Root Cause: When integration tests perform service startup readiness probes (/i/status) or federation ingress warmup probes (/rpc/.../api-version), probes may time out or cancel early while unconsumed response bytes (such as from concurrent /i/metrics scrapes) remain in socket buffers. If these probe requests share the primary HTTP.Manager connection pool, dirty sockets containing leftover response bytes can be checked out by subsequent test requests, returning unexpected status 200 text/plain metrics responses and causing assertion failures in checkFederationIngress. Fix: - Add a dedicated probeManager field to GlobalEnv and Env initialized with managerIdleConnectionCount = 0 so that probe connections are never cached or reused across requests. - Add submitProbe helper in Testlib.HTTP using probeManager. - Update checkServiceIsUp and checkFederationIngress in Testlib.ModService to execute probe requests via submitProbe.
zebot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit configures a dedicated HTTP.Manager for probe requests with managerIdleConnectionCount = 0 to prevent connection pool pollution during startup.
Background & Root Cause:
When integration tests perform service startup readiness probes (/i/status) or federation ingress warmup probes (/rpc/.../api-version), probes may time out or cancel early while unconsumed response bytes (such as from concurrent /i/metrics scrapes) remain in socket buffers.
If these probe requests share the primary HTTP.Manager connection pool, dirty sockets containing leftover response bytes can be checked out by subsequent test requests, returning unexpected status 200 text/plain metrics responses and causing assertion failures in checkFederationIngress.
Fix:
Checklist
changelog.d