WPB-23631: Cache the public key bundle at startup instead of an effect - #5393
Open
blackheaven wants to merge 6 commits into
Open
WPB-23631: Cache the public key bundle at startup instead of an effect#5393blackheaven wants to merge 6 commits into
blackheaven wants to merge 6 commits into
Conversation
blackheaven
added
the
ok-to-test
akshaymankar
requested changes
Aug 3, 2026
akshaymankar
left a comment
akshaymankar
left a comment
Member
There was a problem hiding this comment.
Its weird that this is an effect. We should read the file at startup and keep it cached instead of reading it all the time.
blackheaven
changed the title
Brig.Effects.PublicKeyBundle in Wire.PublicKeyBundle
blackheaven
force-pushed
the
gdifolco/WPB-23631-migrate-brig-galley-spar-effects-7
branch
from
August 3, 2026 15:21
f7f9ea1 to
a4c1acc
Compare
Move the PublicKeyBundle effect + interpreter to Wire.PublicKeyBundle (single module). Rewire consumers (CanonicalInterpreter, Brig.API.Public, Brig.User.Client); delete old module; register in cabal.
blackheaven
force-pushed
the
gdifolco/WPB-23631-migrate-brig-galley-spar-effects-7
branch
from
August 3, 2026 19:52
cdc3123 to
a903dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23631
Checklist
changelog.d